T180: the DCO changelog entry is about a git signature, not a receipt - #13
Conversation
CTRLRun/ctrlrun#169 added a CHANGELOG entry explaining why the DCO check refused every Dependabot pull request. It says signs off and GitHub's own signature, and T180 scans the kernel's release documents for exactly those words, so docs main went red against a kernel main that had merged an hour earlier. The last green run predates that merge. Both phrases are ANOTHER_SUBJECT's case, which is what that half of the allow-list is for: the Developer Certificate of Origin trailer on a git commit, and GitHub's signature on that commit read back through its API. Neither is a signature on a receipt, which is the thing SPEC-v0.6 §6.4 says this project does not do. Signed-off-by: arpan <contact@arpanghoshal.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
|
Warning Review limit reachedNext included review available in 34 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe release document test allowlist now includes a v0.9 changelog entry about the DCO check. Comments identify its sign-off and GitHub signature terms as non-receipt references. ChangesRelease Document Validation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The conflicts were all in generated files, so they are resolved by running the generators rather than by hand-merging two renders. The Python line this branch adds survives it: 'Python 3.11 and later, tested on 3.11 to 3.14'. T180 still fails here for a reason that belongs to main, not to this branch: the DCO entry CTRLRun/ctrlrun#169 added to the kernel's CHANGELOG trips the signature scan. PR #13 allow-lists it. Signed-off-by: arpan <arpanghoshalwork@gmail.com>
CTRLRun/ctrlrun#150 put the postgres extra in the docs lock so that job collects the suite the check job runs. It collects five more tests than the block recorded, which the audit does not fail on, because it only fails when the block claims MORE than the suite collects. Understating is still not the number. Signed-off-by: arpan <contact@arpanghoshal.com>
1 participant
docs
mainis red right now, and the last green run on it predates the cause.CTRLRun/ctrlrun#169 added a CHANGELOG entry explaining why the DCO check refused every Dependabot pull request. It says "signs its commits off" and "GitHub's own signature", and T180 scans the kernel's release documents for exactly those words. The docs CI run that went green on main checked out the kernel before #169 merged; the next run against current kernel main fails.
Both phrases are
ANOTHER_SUBJECT's case, which is what that half of the allow-list exists for: the Developer Certificate of Origin trailer on a git commit, and GitHub's signature on that commit read back through its API. Neither is a signature on a receipt, which is the thingSPEC-v0.6.md§6.4 says this project does not do.scripts/check.shgreen against current kernel main: 1,686 tests, every generator, lint and links.Summary by CodeRabbit