BB2-4929 replace notify_no_data and no_data_timeframe with on_missing_data#526
Draft
annamontare-nava wants to merge 2 commits into
Draft
BB2-4929 replace notify_no_data and no_data_timeframe with on_missing_data#526annamontare-nava wants to merge 2 commits into
annamontare-nava wants to merge 2 commits into
Conversation
This seems to be the new way of doing things, and matches what's in the Datadog UI. Need to do some more thinking to understand what the correct setting is for each of the monitors. https://docs.datadoghq.com/monitors/guide/on_missing_data/
| } | ||
|
|
||
| # TODO this maybe doesn't make sense to be global across all the monitors for a technology | ||
| on_missing_data = var.monitor_config.lambda.on_missing_data |
Contributor
Author
There was a problem hiding this comment.
@mianava This monitor didn't have the notify_no_data options on it, was that intentional?
Contributor
Author
There was a problem hiding this comment.
Same for some of the rds ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
BB2-4929
🛠 Changes
switch to on_missing_data, which is more flexible
Teams will have to update their configuration to use this change.
Need to do some more thinking to understand what the correct setting is for each of the monitors.
ℹ️ Context
This seems to be the new way of doing things, and matches what's in the Datadog UI.
https://docs.datadoghq.com/monitors/guide/on_missing_data/
🧪 Validation
TODO