Plt 1618/cdapmgmt#502
Draft
mianava wants to merge 14 commits into
Draft
Conversation
## 🎫 Ticket PLT-1691 https://jira.cms.gov/browse/... ## 🛠 Changes <!-- What was added, updated, or removed in this PR? --> Remove the BBAPI string in favor of flexible use. ## ℹ️ Context Bluebutton was not able to filter on BB for monitors and could therefore not see their monitors. <!-- Why were these changes made? Add background context suitable for a non-technical audience. --> <!-- If any of the following security implications apply, this PR must not be merged without Stephen Walter's approval. Explain in this section and add @SJWalter11 as a reviewer. - Adds a new software dependency or dependencies. - Modifies or invalidates one or more of our security controls. - Stores or transmits data that was not stored or transmitted before. - Requires additional review of security implications for other reasons. --> ## 🧪 Validation These changes are validated by applying the module in bluebutton. <!-- How were the changes verified? Did you fully test the acceptance criteria in the ticket? Provide reproducible testing instructions and screenshots if applicable. -->
## 🎫 Ticket https://jira.cms.gov/browse/AB2D-7301 ## 🛠 Changes Fixes three small bugs in the service module encountered when upgrading to account for new Datadog sidecars. ## ℹ️ Context Needed to facilitate the rest of AB2D-7301: CMSgov/ab2d#1801 ## 🧪 Validation Applied these changes manually to lower environments. See CMSgov/ab2d#1801
## 🎫 Ticket https://jira.cms.gov/browse/AB2D-7301 ## 🛠 Changes Adds ALB target group protocol variable to service module ## ℹ️ Context As part of the ongoing updates to the AB2D terraform to enable the new Datadog sidecar modules, we are updating some of the networking around our API as well. This prevents errors on ECS services that are expecting TLS traffic (APIs, normally) ## 🧪 Validation Should alleviate HTTP 400 errors in AB2D test as a part of the ongoing changes in CMSgov/ab2d#1801
## 🎫 Ticket https://jira.cms.gov/browse/PLT-1694 ## 🛠 Changes - test.sopsw.yaml: include pre-generated Datadog Private Location Config ## ℹ️ Context Since creating a Datadog Private Location via terraform emits sensitive info into tfstate, we want to use sops to manage the values previously generated when creating the PL. This will allow us to destroy the TFstate and ensure no sensitive data is leaked. ## 🧪 Validation Will be tested after merge.
## 🎫 Ticket https://jira.cms.gov/browse/PLT-1694 ## 🛠 Changes - terraform/modules/sops/main.tf: This change allows sops to handle nested objects using jsonencode() - terraform/services/010-config/values/test.sopsw.yaml: new values due to tofu destroy/apply ## ℹ️ Context Sops was failing to apply due to Datadog config being a nested object. ## 🧪 Validation Tested via local apply to test environment. Plan will fail because sops module version is pinned to an older version without this change.
## 🎫 Ticket https://jira.cms.gov/browse/PLT-1694 ## 🛠 Changes Update sops module commit ref. ## ℹ️ Context Resolves issue where sops couldn't handle nested values. ## 🧪 Validation Should result in successful tofu plan action.
## 🎫 Ticket PLT-1706 ## 🛠 Changes <!-- What was added, updated, or removed in this PR? --> Modifies datadog agent sidecar to be readonly by setting up volumes and mount points. ## ℹ️ Context <!-- Why were these changes made? Add background context suitable for a non-technical audience. --> These changes are made to ensure READONLY is consistent per NIST requirements. <!-- If any of the following security implications apply, this PR must not be merged without Stephen Walter's approval. Explain in this section and add @SJWalter11 as a reviewer. - Adds a new software dependency or dependencies. - Modifies or invalidates one or more of our security controls. - Stores or transmits data that was not stored or transmitted before. - Requires additional review of security implications for other reasons. --> ## 🧪 Validation These changes were validated by using ecs-stack and ensuring a task came up including the datadog container. <!-- How were the changes verified? Did you fully test the acceptance criteria in the ticket? Provide reproducible testing instructions and screenshots if applicable. -->
## 🎫 Ticket PLT-1707 ## 🛠 Changes This changes dependencies to ensure vulnerability is reduced. <!-- What was added, updated, or removed in this PR? --> ## ℹ️ Context <!-- Why were these changes made? Add background context suitable for a non-technical audience. --> These changes were made based on dependabot alert that indicated esbuild must be updated. <!-- If any of the following security implications apply, this PR must not be merged without Stephen Walter's approval. Explain in this section and add @SJWalter11 as a reviewer. - Adds a new software dependency or dependencies. - Modifies or invalidates one or more of our security controls. - Stores or transmits data that was not stored or transmitted before. - Requires additional review of security implications for other reasons. --> ## 🧪 Validation These changes are validated by the git workflow checks successfully running the action. <!-- How were the changes verified? Did you fully test the acceptance criteria in the ticket? Provide reproducible testing instructions and screenshots if applicable. -->
## 🎫 Ticket https://jira.cms.gov/browse/PLT-1694 ## 🛠 Changes - terraform/modules/sops/main.tf: This change allows sops to handle nested objects using jsonencode() - terraform/services/010-config/values/test.sopsw.yaml: new values due to tofu destroy/apply ## ℹ️ Context Sops was failing to apply due to Datadog config being a nested object. ## 🧪 Validation Tested via local apply to test environment. Plan will fail because sops module version is pinned to an older version without this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/...
🛠 Changes
ℹ️ Context
🧪 Validation