Skip to content

Convert is_uniformly_false() method calls to attribute access #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shanest merged 2 commits into from
Jan 26, 2026
Merged

Convert is_uniformly_false() method calls to attribute access #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6063bd6
Initial plan
Copilot Jan 26, 2026
3cda6a0
Update is_uniformly_false() call sites to attribute access
Copilot Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/examples/indefinites/scripts/generate_expressions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# filter out the trivial meaning, results in NaNs
# iterate over keys, since we need to change the dict itself
for meaning in list(expressions_by_meaning.keys()):
if meaning.is_uniformly_false():
if meaning.is_uniformly_false:
del expressions_by_meaning[meaning]

print(f"Generated {len(expressions_by_meaning)} unique expressions.")
Expand Down
2 changes: 1 addition & 1 deletion src/examples/learn_quant/scripts/generate_expressions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def enumerate_quantifiers(
# filter out the trivial meaning, results in NaNs
# iterate over keys, since we need to change the dict itself
for meaning in list(expressions_by_meaning.keys()):
if meaning.is_uniformly_false():
if meaning.is_uniformly_false:
del expressions_by_meaning[meaning]

return expressions_by_meaning
Expand Down
2 changes: 1 addition & 1 deletion src/examples/modals/scripts/generate_expressions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# filter out the trivial meaning, results in NaNs
# iterate over keys, since we need to change the dict itself
for meaning in list(expressions_by_meaning.keys()):
if meaning.is_uniformly_false():
if meaning.is_uniformly_false:
del expressions_by_meaning[meaning]

print(f"Generated {len(expressions_by_meaning)} unique expressions.")
Expand Down
2 changes: 1 addition & 1 deletion src/examples/modals/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ def dataframe_to_language(
)

if (
meaning.is_uniformly_false()
meaning.is_uniformly_false
): # often there will be no usable referents due to can_express being False, above
continue
# search for a matching recorded meaning
Expand Down
Loading