Skip to content

ci: sync stale workflow copies with current CLDMV/.github templates - #12

Closed
Shinrai wants to merge 2 commits into
nextfrom
ci/fix-workflow-drift
Closed

ci: sync stale workflow copies with current CLDMV/.github templates#12
Shinrai wants to merge 2 commits into
nextfrom
ci/fix-workflow-drift

Conversation

@Shinrai

@Shinrai Shinrai commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Fixes three real, currently-latent bugs found by diffing this repo's adopted workflows against the current CLDMV/.github templates, plus a header correction.

  • master-commit-audit.yml: migrated to the thin-caller form (uses: reusable-master-commit-audit.yml@v4) so the commit-subject pattern lives centrally instead of a hardcoded per-repo regex. The old regex lacked the "( - description)" group, so it would have false-positived and auto-filed a spurious issue on every real release-PR merge.
  • next-release.yml / hotfixes-release.yml: fixed the release-PR loop-guard to gate on github.event_name != 'push' instead of github.actor != 'cldmv-bot[bot]'. The old actor-based guard silently skipped the release-PR lane for any bot-authored merge - fatal on hotfixes, where every merge is a bot auto-merge.
  • dependabot-auto-merge.yml: dropped the merge_method: "squash" override. next/hotfixes rulesets only allow the merge method, so Dependabot auto-merge attempts were being rejected outright.
  • Header fix: the copied files carried over @Project/@filename pointing at CLDMV/.github's example path instead of self-referencing this repo.

This branch predates feature-pr.yml landing on next (#5), so it never got an auto-opened PR - opening manually now that the CI/CD setup for this repo isn't fully bootstrapped yet.

Shinrai added 2 commits July 18, 2026 16:32
- master-commit-audit.yml: migrate to the thin-caller form so the
  commit-subject pattern lives in reusable-master-commit-audit.yml@v4
  instead of a hardcoded per-repo regex. The old regex lacked the
  "( - description)" group, so it would have false-positived on every
  real release-PR merge (e.g. "release: v1.1.0 - guard modes...").
- next-release.yml / hotfixes-release.yml: fix the release-PR
  loop-guard back to gating on push vs workflow_dispatch instead of
  github.actor. The old actor-based guard silently skipped the
  release-PR lane for any bot-authored merge - fatal on hotfixes,
  where every merge is a bot auto-merge.
- dependabot-auto-merge.yml: drop the merge_method: "squash" override.
  next/hotfixes rulesets only allow the "merge" method, so Dependabot
  auto-merge attempts were being rejected outright.
Copying the example files verbatim carried over their @Project/
@filename header pointing at CLDMV/.github's example path. Every
adopted workflow file should self-reference the consuming repo,
matching the convention slothlet already uses.
@cldmv-bot
cldmv-bot Bot deleted the branch next July 19, 2026 06:04
@cldmv-bot cldmv-bot Bot closed this Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant