ci: restrict the Node test matrix to LTS majors by default - #11
Merged
Conversation
The matrix ran full (20/21/22/lts) on every event except direct pushes to master (`lts_only_matrix` was off-by-default). Node 21 is a non-LTS interim release the native-binding test toolchain (vitest 4 / rolldown / vite 8) excludes via `engines` (`^20.19.0 || >=22.12.0`), so its matrix leg dies at startup with "Cannot find native binding" — not a real per-version regression. This is what turned CI red on next: the release PR #3 runs as a pull_request event (ref refs/pull/3/merge), so it never matched the master-only LTS toggle and got the full matrix incl. the broken 21 leg. Default `lts_only_matrix` on for all events (workflow_dispatch can still opt out with false). Matrix is now 20/22/lts — the broken 21 leg is gone, per the LTS-only-majors CI policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What's Changed
💥 Breaking Changes
No breaking changes
✨ Features
No new features
🐛 Bug Fixes
No bug fixes
📦 Dependencies
No dependency updates
🔧 Other Changes
👥 Contributors