Skip to content

Conversation

@f-allian
Copy link
Collaborator

@f-allian f-allian commented Jan 5, 2026

This pull request introduces improvements to the DAFNI containerization and workflow for the Causal Testing Framework. The main changes include a more flexible and automated entrypoint script, enhanced configuration via environment variables, improved documentation, and some workflow and metadata updates.

Containerization and Workflow Automation:

  • Added a new entrypoint.sh script that auto-detects whether to generate or test causal tests based on the presence of the causal_tests.json file, or allows explicit override via the EXECUTION_MODE environment variable. All command-line options are now configurable through the .env file. (dafni/entrypoint.sh, dafni/Dockerfile, dafni/.env, dafni/README.md) [1] [2] [3] [4]

Configuration and Environment:

  • Centralized all configuration (input/output filenames, estimator options, execution mode, and other parameters) into the .env file, making the Docker image and workflow more flexible and easier to maintain. (dafni/.env, dafni/README.md) [1] [2]
  • Updated the Dockerfile to use the new entrypoint script and corrected the maintainer label. (dafni/Dockerfile) [1] [2]

Documentation Improvements:

  • Expanded the DAFNI-specific README.md to clarify directory structure, configuration, workflow, and usage of the .env file. Also updated the main README.md with contact information and corrected example command-line arguments to use the new flag names. (dafni/README.md, README.md) [1] [2] [3]

Workflow and CI Adjustments:

  • Simplified the GitHub Actions workflow for publishing to DAFNI: now only the major version is extracted from the release tag, and the unit test step was removed from the publish workflow. (.github/workflows/publish-to-dafni.yaml) [1] [2] [3]
image

@f-allian f-allian requested a review from jmafoster1 January 5, 2026 16:54
@f-allian f-allian self-assigned this Jan 5, 2026
@f-allian f-allian added the enhancement New feature or request label Jan 5, 2026
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 33 0 1.01s
✅ PYTHON pylint 33 0 6.48s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.64%. Comparing base (045246d) to head (38ef8d8).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files          28       28           
  Lines        1608     1608           
=======================================
  Hits         1554     1554           
  Misses         54       54           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d274678...38ef8d8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@jmafoster1 jmafoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a couple of little typos/inconsistencies, but otherwise looks good.

@f-allian
Copy link
Collaborator Author

f-allian commented Jan 6, 2026

@jmafoster1 Thanks Michael. There's a quick bug in the model definition - I'm just trying to debug it. I'll fix that then I'll merge.

@f-allian f-allian merged commit 8fa3189 into main Jan 9, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants