-
Notifications
You must be signed in to change notification settings - Fork 5
Updating the DAFNI Workflow #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 96.64% 96.64%
=======================================
Files 28 28
Lines 1608 1608
=======================================
Hits 1554 1554
Misses 54 54 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jmafoster1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed a couple of little typos/inconsistencies, but otherwise looks good.
|
@jmafoster1 Thanks Michael. There's a quick bug in the model definition - I'm just trying to debug it. I'll fix that then I'll merge. |
This pull request introduces improvements to the DAFNI containerization and workflow for the Causal Testing Framework. The main changes include a more flexible and automated entrypoint script, enhanced configuration via environment variables, improved documentation, and some workflow and metadata updates.
Containerization and Workflow Automation:
entrypoint.shscript that auto-detects whether to generate or test causal tests based on the presence of thecausal_tests.jsonfile, or allows explicit override via theEXECUTION_MODEenvironment variable. All command-line options are now configurable through the.envfile. (dafni/entrypoint.sh,dafni/Dockerfile,dafni/.env,dafni/README.md) [1] [2] [3] [4]Configuration and Environment:
.envfile, making the Docker image and workflow more flexible and easier to maintain. (dafni/.env,dafni/README.md) [1] [2]dafni/Dockerfile) [1] [2]Documentation Improvements:
README.mdto clarify directory structure, configuration, workflow, and usage of the.envfile. Also updated the mainREADME.mdwith contact information and corrected example command-line arguments to use the new flag names. (dafni/README.md,README.md) [1] [2] [3]Workflow and CI Adjustments:
.github/workflows/publish-to-dafni.yaml) [1] [2] [3]