Repository navigation
Conversation
Every home claimed on 0.5.189 or later signs as the AGENT key, binds its owner to a separate NODE key, and ties the agent to the human only as an occurrence (`self:delegates_to:agent_occurrence:v1`). tests/agent_deferral.rs covered only the unsplit home (engine key = node key), so persist's #1120 identity_amendment gate could not be checked against the shape Server actually writes. This adds it. Green on persist v59 (no gate); the first test to run at the persist 60.1 adoption, whose gate admits the shape via the occurrence anchor (CIRISPersist PR #1135, witness I1368). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QriZxPx5aJvHXCGaTZmvKF
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every home claimed on 0.5.189 or later is a split home:
self:delegates_to:agent_occurrence:v1, from the login ceremony).I confirmed this shape against the production canonical's rows for a 0.5.237 gate node.
tests/agent_deferral.rsonly built unsplit homes, where the engine key is the node key. So persist v60.1's newidentity_amendment:v1gate (#1120) could not be checked against the shape Server writes. That gate would have refused this shape until persist relaxed it (PR #1135, witness I1368).What
The new test,
a_split_home_amendment_is_authorised_by_the_nodes_owner, builds that home and runs the full deferral → approval → amendment chain:self_at_loginanchoring the agent as the owner's occurrence.It asserts the preconditions (
owner_of(agent) = None,owner_of(node) = owner) and that the agent key signs the amendment.It passes on persist v59, which has no gate. It runs first when we adopt persist 60.1.
The PR changes tests only.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QriZxPx5aJvHXCGaTZmvKF