Repository navigation
0.5.239: a contact resolves to their node — adopt CIRISEdge v43.2.1 (#907) - #824
Merged
Merged
Conversation
After an add, a node behind the canonical held the contact's Key but not their announced owner-binding, so the directed consent grant had no node to reach (five-platform run 2026-10-26, request:android<-linux). The pending-contacts pass now tracks an added contact until their person resolves to a node: each pass it subject-Pulls the person's records from every consent peer, then the resolved node's key, occurrence and route; `contacts: CONTACT UNRESOLVED` WARNs after 60 s. tests/contact_key_pull_e2e.rs::a_contacts_announced_owner_binding_arrives_on_a_subject_pull is RED on edge v43.2.0 (the canonical refuses the Attestation subject Pull) and goes green on the edge patch for CIRISEdge#907. Not to be pushed until that pin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QriZxPx5aJvHXCGaTZmvKF
…ject Pull Edge v43.2.1 (067dbd7a; persist v59.1.0 / verify v20.2.0 unchanged): a conferred server answers a stranger's Attestation subject Pull with the subject's live, announced, federation-scope owner-bindings and root acceptances, for nodes it publishes. The contact-resolution probe now passes (red on v43.2.0, green here); its canonical bridge carries the production announced-relay selector, without which edge serves nothing (correctly). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QriZxPx5aJvHXCGaTZmvKF
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
0.5.207-0.5.220 were deleted from PyPI on 2026-10-26 to get under the 10 GiB project cap, so the lane failed at 'ciris-server==0.5.207 is not installable'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QriZxPx5aJvHXCGaTZmvKF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Five-platform run 40415548665, on 0.5.238. The contact add from linux to android now converges in 20 s, but the next step,
request:android<-linux, stayed red.delegates_toowner → node, at federation). So the directed consent grant had no node to reach.What
announced_nodes_of). Every 10 s pass, it subject-Pulls the person's records from each consent peer (pull_subject_testimony). Once the person resolves, it also pulls the node's key, occurrence and route, then nudges replication so the grant travels.contacts: CONTACT UNRESOLVEDfires after 60 s and names the hop to check next.Tests
tests/contact_key_pull_e2e.rs::a_contacts_announced_owner_binding_arrives_on_a_subject_pullcovers the fix:announced_relayselector. The asker holds only the contact's keys.Local runs, all green:
-D warningsThe localization guard also passes against client 0.5.233.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QriZxPx5aJvHXCGaTZmvKF