Repository navigation
0.5.238: client floor 0.5.232 (main red fix) + adopt CIRISEdge v43.2.0 - #823
Merged
Merged
Conversation
Main went red after #822 merged, though the PR was green: CIRISClient 0.5.232 published in between and localizes the staged owner-binding ids (`sign_owner_binding.*`, `upgrade_owner.*`, CIRISServer#811) and the contact request ignore ids (CIRISServer#818). The guard fails a stale debt entry, so all fourteen come off KNOWN_UNLOCALIZED, MAX_UNCOVERED drops 33 -> 19, and the pyproject floor rises to 0.5.232 (so CI cannot install a client that renders them in English) with the one evidence row that names the floor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QriZxPx5aJvHXCGaTZmvKF
Edge v43.2.0 adds pre-seal route fetch, dial-path re-keying (#867/#879), throttled steady-state WARNs (#875), opt-in bundle-bootstrap peers (#881) and CC 5.4.3 link shaping. The one source break: ReticulumTransportConfig gained `shaping`. compose.rs, the lens relay and tests/nat_traversal.rs set it to the default (`off`), so the re-pin does not change any node's network posture. TARGET_EDGE and the README pin line move with it. No version bump here: this rides whichever cut Eric picks (0.5.238 or 0.5.239). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QriZxPx5aJvHXCGaTZmvKF
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QriZxPx5aJvHXCGaTZmvKF
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why main is red
#822 was green as a PR. Main then failed
localization_gateon all three OSes, plus the Localization guard job. CIRISClient 0.5.232 was published in between, and it now localizes 14 ids that were still onKNOWN_UNLOCALIZED:sign_owner_binding.*andupgrade_owner.*(Remotely claimed nodes lose their owner across the 0.5.189 agent/node key split (no owner signer on disk) #811)contacts.{delegate_may_not_answer,request_not_found,request_not_ignored}(Contact requests are invisible: no reader for grants others signed naming you #818)The guard fails on a stale debt entry, by design.
What
MAX_UNCOVEREDdrops from 33 to 19.ciris-client>=0.5.232,<0.6. The oneciris-client@evidence row moves with it, ascheck_evidence.pyrequires.ReticulumTransportConfig.shapingfield. compose, the lens relay andtests/nat_traversal.rsset it to its default (off), so no node's network behaviour changes.TARGET_EDGEand the README pin line move with it.Local checks
All green:
--strictand--self-test, against client 0.5.232check_evidence.py-D warningsrelease_gates,replication_policy_gate,substrate_contract_gate,wire_vocabulary_gate,nat_traversal,contact_key_pull_e2e,field_conformance,log_citationsandlocalization_gateThe PR is labelled
ci:fullbecause the edge bump touches transport.🤖 Generated with Claude Code
https://claude.ai/code/session_01QriZxPx5aJvHXCGaTZmvKF