Repository navigation
fix(localize): the translate lane never reports a kept value as written - #266
Merged
Merged
Conversation
With explicit --keys the translate lane selected keys that already had a value, translated and evaluated them, then silently dropped every draft (insert never overwrites in that lane) while printing "[write] es: 4 value(s)". The collect step found nothing to commit and the run went green (CIRISAgent run 40962921351: the rewritten U1 safety exemplar kept its old Spanish). - insert() returns the keys it kept because a value was already there. - The write line says what was written and what was KEPT, names the remedies, and a run that kept any selected key exits 1. - --overwrite replaces existing values in the translate lane. It is not implied by --keys: an existing value may be a hand-written overrule (TRANSLATION_GUIDE §1), and a broad pattern would clobber it silently. Checked against the real bundles: without --overwrite an existing value is reported kept and unchanged; with it, replaced. pytest testing/ 737 passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ZeGbVvLGSbRHPJQJA1dao
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug report from CIRISAgent run 40962921351. With explicit
--keys, the translate lane translated and evaluated keys that already had values, then silently dropped every draft while printing[write] es: 4 value(s). The run went green, and the rewritten safety exemplar kept its old Spanish.insert()returns the keys it kept.--overwritereplaces existing values in the translate lane. It is deliberately not implied by--keys: an existing value may be a hand-written overrule (TRANSLATION_GUIDE §1), and a broad pattern would clobber it silently.Verified against the real bundles (then restored):
--overwrite, the value is kept and unchanged, and reported;The
--dry-runplan is unchanged, and pytesttesting/passes (737). The README notes the behaviour.🤖 Generated with Claude Code
https://claude.ai/code/session_019ZeGbVvLGSbRHPJQJA1dao