Conversation
pvelesko
force-pushed
the
fix-11260-launchhost
branch
2 times, most recently
from
3098147 to
b7c539b
Compare
pvelesko
force-pushed
the
fix-11260-launchhost
branch
4 times, most recently
from
3bb2d3b to
0fe4c20
Compare
- Adds explicit host synchronization on queue sync events before adding barriers that wait on them. - When addDependenciesQueueSync appends a signal event to another queue's command list, the GPU may not process it before we call zeEventHostSynchronize. Add a zero-timeout flush to force the driver to submit the signal command immediately. - Modified the synchronization mechanism for queue events to use a short timeout instead of blocking indefinitely. This change addresses potential hangs by ensuring that the GPU-side barrier maintains properxq ordering without waiting indefinitely for events to be ready.
pvelesko
force-pushed
the
fix-11260-launchhost
branch
from
0fe4c20 to
769ddaf
Compare
addDependenciesQueueSync and addCallback previously flushed only the active queue (get()). When a stream switches to profiling mode after hipEventRecord, ClProfilingQueue_ depends on ClRegularQueue_ via switchModeTo; both must be flushed for cross-queue deps to work on Mali. Fixes TestHipLaunchHostFuncMultiStream timeout on Mali-G52.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hipLaunchHostFunc Hangs Intermittently on Aurora with Level Zero Backend #1126