Repository navigation
fix(learn): ship the exporters' Jinja templates in the wheel and sdist - #40
Merged
Merged
Conversation
packages/akms_learn/pyproject.toml declared no package data, so the 0.3.2 wheel and sdist carry none of templates/*.md.j2 or exporters/templates/*.html.j2. The exporters load them from beside their modules, so every markdown or HTML export from a pip install raised jinja2.TemplateNotFound. Declares them as package data and adds a public smoke test (run by CI against the built wheels) that checks each template ships and parses: 6 passed on the fixed wheel, 6 failed on the published 0.3.2 wheel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CodeQL flags jinja2.Environment() without autoescape as an XSS risk. The smoke test only parses templates and renders nothing, but enabling select_autoescape for HTML/XML matches the HTML exporter and clears the alert. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packages/akms_learn/pyproject.toml declared no package data, so the 0.3.2 wheel and sdist carry none of templates/.md.j2 or exporters/templates/.html.j2. The exporters load them from beside their modules, so every markdown or HTML export from a pip install raised jinja2.TemplateNotFound. Declares them as package data and adds a public smoke test (run by CI against the built wheels) that checks each template ships and parses: 6 passed on the fixed wheel, 6 failed on the published 0.3.2 wheel.