Skip to content

fix(ep): hide request link without read permission - #1062

Open
TahaKhan998 wants to merge 1 commit into
CERNDocumentServer:masterfrom
TahaKhan998:fix/issue-1027-ep-approval-request-link
Open

TahaKhan998 wants to merge 1 commit into
CERNDocumentServer:masterfrom
TahaKhan998:fix/issue-1027-ep-approval-request-link

Conversation

@TahaKhan998

@TahaKhan998 TahaKhan998 commented Nov 12, 2026 •

Copy link
Copy Markdown

closes #1027
record owners were seeing the ep approval request link even though they cant open the request (permission denied). step 3 also looked done for them after approval just because they cant create the public version.

now we only include the request link if the current user can actually read the request, and step 3 is only marked done when a public record exists.

Record not created yet:

image image

Record after being published:

Owner of the community's view:
image

Owner of the record's view:
image

@zzacharo

Copy link
Copy Markdown
Contributor

@TahaKhan998 what about the steps where the user doesnt have access and there is no request created yet or it is still pending? what do we show?

@TahaKhan998

Copy link
Copy Markdown
Author

@TahaKhan998 what about the steps where the user doesnt have access and there is no request created yet or it is still pending? what do we show?

heres what it looks like for the different roles:

  1. no request yet - record owner
image
  1. no request yet - community owner
image
  1. pending - record owner
image
  1. pending - community owner
image

record owner still sees the steps, just no buttons/links. community owner gets the buttons. referee cant open the restricted record until they have access

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EP Approval Request Workflow improvements

2 participants