Repository navigation
fix(ep): hide request link without read permission - #1062
Open
TahaKhan998 wants to merge 1 commit into
Open
TahaKhan998 wants to merge 1 commit into
TahaKhan998 wants to merge 1 commit into
Conversation
Contributor
|
@TahaKhan998 what about the steps where the user doesnt have access and there is no request created yet or it is still pending? what do we show? |
Author
heres what it looks like for the different roles:
record owner still sees the steps, just no buttons/links. community owner gets the buttons. referee cant open the restricted record until they have access |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




closes #1027
record owners were seeing the ep approval request link even though they cant open the request (permission denied). step 3 also looked done for them after approval just because they cant create the public version.
now we only include the request link if the current user can actually read the request, and step 3 is only marked done when a public record exists.
Record not created yet:
Record after being published:
Owner of the community's view:

Owner of the record's view:
