Skip to content

feat(config): move committee approval to admin panel - #1050

Open
liptakpanna wants to merge 1 commit into
CERNDocumentServer:masterfrom
liptakpanna:ep-admin-config
Open

liptakpanna wants to merge 1 commit into
CERNDocumentServer:masterfrom
liptakpanna:ep-admin-config

Conversation

@liptakpanna

@liptakpanna liptakpanna commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Closes #994

  • Moving committee approval config to the DB and the admin panel

command to move the config values to the db:
invenio cds-admin seed-committee-communities -- Option to move to Alembic migration

Possible extension points:

  • Searchable field for roles (not available for admin forms right now)
  • Can more than 1 group be the referee group?

Admin panel

Screenshot 2026-11-06 at 14 33 02

@liptakpanna
liptakpanna marked this pull request as draft November 6, 2026 10:41
@liptakpanna
liptakpanna force-pushed the ep-admin-config branch 3 times, most recently from 829dbef to 01f9990 Compare November 6, 2026 13:16
@liptakpanna
liptakpanna marked this pull request as ready for review November 6, 2026 13:29

@zzacharo zzacharo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liptakpanna can you make sure you document the fact we need to run the alembic recipe for our next deployment?

from sqlalchemy_utils.types import UUIDType


class CommitteeApprovalCommunity(db.Model, Timestamp):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liptakpanna can you make sure that the search queries we do are indexed and we dont hit any performance issue?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and creating an index doesn't help the "ilike" type filtering, so I didn't add any.

@liptakpanna

Copy link
Copy Markdown
Contributor Author

As discussed in person, I renamed it to CommiteeApprovalEnrollment.
Also, I checked adding the autocomplete searchable field, but invenio-administration has React v18, so I would prefer to address this after CDS-RDM is upgraded. Created an issue for it #1061

@zzacharo

Copy link
Copy Markdown
Contributor

As discussed in person, I renamed it to CommiteeApprovalEnrollment. Also, I checked adding the autocomplete searchable field, but invenio-administration has React v18, so I would prefer to address this after CDS-RDM is upgraded. Created an issue for it #1061

Can you create the field already? I think we can either way merge this later on once we also upgrade.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

administration page: configure communities to allow EP approval

2 participants