Repository navigation
fix(harvester): backfill files from ui json - #1049
Closed
TahaKhan998 wants to merge 1 commit into
Closed
TahaKhan998 wants to merge 1 commit into
TahaKhan998 wants to merge 1 commit into
Conversation
TahaKhan998
force-pushed
the
fix/harvester-inspire-ui-documents
branch
from
November 6, 2026 13:26
d933541 to
83855e5
Compare
kpsherva
reviewed
Nov 8, 2026
| current_app.logger.debug("Request response is successful (200).") | ||
| return response.json() | ||
|
|
||
| def _merge_documents_from_ui(self, inspire_record): |
Contributor
There was a problem hiding this comment.
aren't we waiting for Micha's response regarding this? shouldn't it be in draft? I am not sure we will need this...
Author
There was a problem hiding this comment.
Yes I opened this pr before Micha's message and forgot to close it. Closed now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
records got created with no PDFs even though inspire shows a pdf. we pull inspire in a format that often misses the file list (we need that format for the cds ids). the website uses another format that does have the files. so now if the first one has no documents, we also check the second and copy the file list from there.