Skip to content

fix(harvester): backfill files from ui json - #1049

Closed
TahaKhan998 wants to merge 1 commit into
CERNDocumentServer:masterfrom
TahaKhan998:fix/harvester-inspire-ui-documents
Closed

TahaKhan998 wants to merge 1 commit into
CERNDocumentServer:masterfrom
TahaKhan998:fix/harvester-inspire-ui-documents

Conversation

@TahaKhan998

@TahaKhan998 TahaKhan998 commented Nov 6, 2026 •

Copy link
Copy Markdown

records got created with no PDFs even though inspire shows a pdf. we pull inspire in a format that often misses the file list (we need that format for the cds ids). the website uses another format that does have the files. so now if the first one has no documents, we also check the second and copy the file list from there.

@TahaKhan998
TahaKhan998 force-pushed the fix/harvester-inspire-ui-documents branch from d933541 to 83855e5 Compare November 6, 2026 13:26
@TahaKhan998 TahaKhan998 changed the title fix(harvester): backfill files from ui json and skip via ctx cds id fix(harvester): backfill files from ui json Nov 6, 2026
current_app.logger.debug("Request response is successful (200).")
return response.json()

def _merge_documents_from_ui(self, inspire_record):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't we waiting for Micha's response regarding this? shouldn't it be in draft? I am not sure we will need this...

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I opened this pr before Micha's message and forgot to close it. Closed now.

@TahaKhan998 TahaKhan998 closed this Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants