Repository navigation
feat(harvester): harvest and handle correction materials - #1042
Conversation
| "files": { | ||
| k: v | ||
| for k, v in metadata.get("files", {}).items() | ||
| if k != "default_preview" |
There was a problem hiding this comment.
why we exclude the file with the default preview from the update method?
There was a problem hiding this comment.
I added a comment to explain: at this point the files are not uploaded yet, so setting the default_preview to a file that is not yet available raises an error. the key is ignored at this point, but used later in the FileSynchronizer
| "corrigendum": {"resource_type": "publication-other"}, | ||
| "addendum": {"resource_type": "publication-other"}, |
There was a problem hiding this comment.
these 2 are not handled yet in the migrator-kit. Are we sure they come from INSPIRE? If so, maybe we can already add them to the list we have in the migrator-kit.
There was a problem hiding this comment.
They are on INSPIRE https://github.com/inspirehep/inspire-schemas/blob/23c49f243fd9fe1e10557a5d92f22965d88b1246/inspire_schemas/records/elements/material.yml#L4
For the migrator-kit: addendum is mentioned here, but not in related identifiers.
Also, the decision log only has erratum, but the issue mentioned all three, so I'm not sure
There was a problem hiding this comment.
Can you confirm with the library and ammend the decision log and migrator kit if agreed please?
There was a problem hiding this comment.
| return True | ||
| if not (source or material): | ||
| return False | ||
| if (not material or material == "publication") and source != "arxiv": |
There was a problem hiding this comment.
I think this can be merged to your new correction_material branch, no?
There was a problem hiding this comment.
I added named conditions to make all the accepted cases clearer
6bb0cd8 to
fc55e11
Compare
|
@liptakpanna also, can you rebase please? |
ca864da to
40d0e51
Compare
40d0e51 to
1908973
Compare
closes #1006
Open questions: