Repository navigation
Update ISOLDE query and fix journal field - #683
Open
zubeydecivelek wants to merge 3 commits into
Open
zubeydecivelek wants to merge 3 commits into
zubeydecivelek wants to merge 3 commits into
Conversation
zubeydecivelek
commented
Nov 10, 2026
| issue = StringValue(value.get("n", "")).parse() | ||
| volume = StringValue(value.get("v", "")).parse() | ||
| pages = StringValue(value.get("c", "")).parse() | ||
| if not (journal_fields and is_correction): |
Contributor
Author
There was a problem hiding this comment.
We should not raise if there is erratum etc multiple 773 journal field
Comment on lines
305
to
319
| conference_cnum = value.get("w", "") | ||
| conference_acronym = value.get("q", "") | ||
| meetings = _custom_fields.get("meeting:meeting", []) | ||
| if conference_cnum or conference_acronym: | ||
| session = StringValue(value.get("c", "")).parse() | ||
| new_meeting = {} | ||
| identifiers = [] | ||
| if conference_url: | ||
| identifiers.append({"scheme": "URL", "identifier": conference_url}) | ||
| if conference_cnum: | ||
| # Some old records have slashes instead of hyphens in the INSPIRE conference cnum | ||
| conference_cnum = conference_cnum.replace("/", "-") | ||
| identifiers.append({"scheme": "inspire", "identifier": conference_cnum}) | ||
| if identifiers: | ||
| new_meeting["identifiers"] = identifiers |
Contributor
Author
There was a problem hiding this comment.
If cnum is missing we were not setting the url identifier, I think we should still add it
zubeydecivelek
force-pushed
the
isolde-update
branch
from
November 10, 2026 18:23
cd52d3d to
02bab0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
773 Journal Field Summary:
Each 773 is handled on its own. p, n, or v means a journal. w or q means a conference. c alone is a temporary page value.
773 :Conference and the rest