Skip to content

Update ISOLDE query and fix journal field - #683

Open
zubeydecivelek wants to merge 3 commits into
CERNDocumentServer:masterfrom
zubeydecivelek:isolde-update
Open

zubeydecivelek wants to merge 3 commits into
CERNDocumentServer:masterfrom
zubeydecivelek:isolde-update

Conversation

@zubeydecivelek

@zubeydecivelek zubeydecivelek commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

773 Journal Field Summary:

Each 773 is handled on its own. p, n, or v means a journal. w or q means a conference. c alone is a temporary page value.

  • The first journal 773 sets journal:journal: p is the title, n the issue, v the volume, c the pages.
  • A later 773 whose m is only erratum, addendum, or corrigendum does not raise and does not overwrite those fields. Its subfields are still read, so dojson does not report a missing rule.
  • If that correction 773 is the only journal 773, it fills the journal. If it comes first, the publication 773 after it raises Multiple journal 773 fields.
  • A second journal 773 with no m, or with m = publication, raises Multiple journal 773 fields.
  • A repeated c in one 773 raises Multiple 773__c values.
  • The erratum link comes from 0247_ $q, stored as issupplementedby, not from 773__m.

773 :Conference and the rest

  • w or q adds a meeting: w is the INSPIRE id (/ becomes -), q the acronym, c the session. u is stored as a URL even when w is absent.
  • A conference 773 does not overwrite an existing journal.
  • c only, with an empty journal, is stored as pages for 962__k. If the journal is already set, it raises Journal fields already set.
  • y alone sets the publication date, or raises Publication date mismatch when the year differs.
  • A valid z becomes an ISBN relation. An invalid z raises Invalid ISBN in 773__z.

@zubeydecivelek zubeydecivelek changed the title Isolde update Update ISOLDE query and fix journal field Nov 10, 2026
issue = StringValue(value.get("n", "")).parse()
volume = StringValue(value.get("v", "")).parse()
pages = StringValue(value.get("c", "")).parse()
if not (journal_fields and is_correction):

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not raise if there is erratum etc multiple 773 journal field

Comment on lines 305 to 319
conference_cnum = value.get("w", "")
conference_acronym = value.get("q", "")
meetings = _custom_fields.get("meeting:meeting", [])
if conference_cnum or conference_acronym:
session = StringValue(value.get("c", "")).parse()
new_meeting = {}
identifiers = []
if conference_url:
identifiers.append({"scheme": "URL", "identifier": conference_url})
if conference_cnum:
# Some old records have slashes instead of hyphens in the INSPIRE conference cnum
conference_cnum = conference_cnum.replace("/", "-")
identifiers.append({"scheme": "inspire", "identifier": conference_cnum})
if identifiers:
new_meeting["identifiers"] = identifiers

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If cnum is missing we were not setting the url identifier, I think we should still add it

@zubeydecivelek zubeydecivelek linked an issue Nov 11, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ISOLDE development

1 participant