Repository navigation
feat(moedal): add new model and yaml file #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zubeydecivelek
wants to merge
1
commit into
CERNDocumentServer:master
Choose a base branch
from
zubeydecivelek:moedal-model
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # -*- coding: utf-8 -*- | ||
| # | ||
| # Copyright (C) 2026 CERN. | ||
| # | ||
| # CDS-RDM is free software; you can redistribute it and/or modify it under | ||
| # the terms of the MIT License; see LICENSE file for more details. | ||
|
|
||
| """CDS-RDM MoEDAL model.""" | ||
|
|
||
| from cds_migrator_kit.rdm.collection_conf import conf_query | ||
| from cds_migrator_kit.rdm.records.transform.models._config import IGNORE_SYSTEM_KEYS | ||
| from cds_migrator_kit.rdm.records.transform.models.base_publication_record import ( | ||
| rdm_base_publication_model, | ||
| ) | ||
| from cds_migrator_kit.rdm.records.transform.models.research import ResearchModel | ||
| from cds_migrator_kit.transform.overdo import CdsOverdo | ||
|
|
||
|
|
||
| class MoEDALModel(CdsOverdo): | ||
| """Translation model for MoEDAL.""" | ||
|
|
||
| __query__ = conf_query("moedal") | ||
|
|
||
| __ignore_keys__ = IGNORE_SYSTEM_KEYS | ResearchModel.__ignore_keys__ | ||
|
|
||
| _default_fields = { | ||
| "custom_fields": {}, | ||
| } | ||
|
|
||
|
|
||
| moedal_model = MoEDALModel( | ||
| bases=(rdm_base_publication_model,), | ||
| entry_point_group="cds_migrator_kit.migrator.rules.moedal", | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| name: moedal | ||
| queries: | ||
| - q: '980__a:PREPRINT AND 693__e:MoEDAL OR 980__a:ARTICLE AND 693__e:MoEDAL OR 980:MoEDAL_NOTES OR 980:MoEDAL_INTERNAL_NOTES' | ||
| dump_file_prefix: moedal | ||
| flags: | ||
| include_plots: true | ||
| create_inclusion_request: true | ||
| preferred_model: moedal | ||
| # These community slugs must exist in the target environment. | ||
| communities: | ||
| - moedal | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: please align on the community slug before going to prod - we should follow a convention, normally we have some "collaboration" suffix in the name |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this give the correct amount of results? No parenthesis needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes