Closed
Conversation
- Added exception handling in `cdec_download`, `des_download`, `nwis_download`, `noaa_download`, and `ncro_download` functions to log failures and return structured failure information. - Updated `populate_repo` to collect and return station failures, writing them to a CSV file for better traceability. - Implemented tests to ensure that downloaders and reformat functions continue processing despite individual station failures, capturing errors in a structured format. - Enhanced `reformat` and `populate` functions to write failure logs even when no errors occur, ensuring a consistent output format. - Added new test cases to validate the handling of failures in the auto-screening and downloading processes, ensuring robustness in error scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error handling for downloaders, reformatters and screeners so that a single station doesn't stop the rest from proceeding.