342 benchcab sub command for do meorg#344
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
==========================================
+ Coverage 68.28% 68.83% +0.55%
==========================================
Files 21 21
Lines 1157 1232 +75
==========================================
+ Hits 790 848 +58
- Misses 367 384 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SeanBryan51
approved these changes
Feb 25, 2026
Collaborator
SeanBryan51
left a comment
There was a problem hiding this comment.
Thanks Ben. This LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the
meorg-transfersubcommand.I note that there are no real tests for the meorg components of benchcab, so here are the outputs from these efforts after having run the vanilla
bench_examplewith the following config:Note,
scratch/tm70was added because that is where I havepixiinstalled for development.Stdout (after successful
benchcab runonbench_examplewith no upload):PBS:
Outputs uploaded to: https://modelevaluation.org/modelOutput/display/kWaGuDaP2qHpknpF9
In addressing this issue, there were problems identified with the docs. These have been raised in #343.
Feel free to ask any questions.