Initialize land_decomp_start to 1

[Whyborn]

CABLE

Description

The recent addition of to_land_index_global in src/offline/cable_iovars.F90 is currently not compatible with running in coupled mode. This routine is called in the land use code, which is intended to be included in coupled applications, so it does need to be included in coupled mode. I believe initialising land_decomp_start to 1 will make this function as expected in coupled applications, where we never call the decomposition initialisation. Do you think this is correct @SeanBryan51?

Type of change

Please delete options that are not relevant.

• Bug fix

Checklist

• The new content is accessible and located in the appropriate section
• I have checked that links are valid and point to the intended content
• I have checked my code/text and corrected any misspellings

Testing

• Are the changes bitwise-compatible with the main branch? If working on an optional feature, are the results bitwise-compatible when this feature is off? If yes, copy benchcab output showing successful completion of the bitwise compatibility tests or equivalent results below this line.

• Are the changes non bitwise-compatible with the main branch because of a bug fix or a feature being newly implemented or improved? If yes, add the link to the modelevaluation.org analysis versus the main branch or equivalent results below this line.

---

📚 Documentation preview 📚: https://cable--725.org.readthedocs.build/en/725/

[SeanBryan51]

Thanks Lachlan, this should be pretty harmless so I'm happy for this to go in. Just a suggestion: would be clearer to set land_decomp_start = 1 in the coupled model (before the land use code is called)? This would make it a bit more obvious that these variables should be set elsewhere at runtime.

[Whyborn]

Yea, I can suss out the best place to do this coupled mode. I think it would be best to introduce a function like set_decomp_coupled or something, that just sets land_decomp_start=1?

[Whyborn]

@SeanBryan51 Made that change- haven't decided where it should be called in coupled mode yet, but I think that can be decided later.

[SeanBryan51]

Thanks Lachlan, happy for this to go in when you are.