Skip to content

Fix snowmelt declaration that should be illegal #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Whyborn wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix snowmelt declaration that should be illegal #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9213aa0
Try changing snowmelt declaration
Whyborn Feb 23, 2026
62f2bdb
Used wrong var in allocate call
Whyborn Feb 23, 2026
fad6880
Add allocatable attribute
Whyborn Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/science/soilsnow/cbl_snowMelt.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
MODULE snow_melting_mod

USE cbl_ssnow_data_mod
USE cable_common_module

PUBLIC snow_melting

CONTAINS

SUBROUTINE snow_melting (dels, snowmlt, ssnow, soil )

USE cable_common_module
IMPLICIT NONE

REAL, INTENT(IN) :: dels ! integration time step (s)

REAL, DIMENSION(mp), INTENT(OUT) :: snowmlt ! snow melt
REAL, DIMENSION(:), ALLOCATABLE, INTENT(OUT) :: snowmlt ! snow melt
Copy link
Copy Markdown
Collaborator

@har917 har917 May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer snowmlt to ALLOCATED in ssnow_main and then passed down into the SUBROUTINEs snow_melting(), cbl_thermal etc. consistently rather than in a lower routine, then up and down.


TYPE(soil_parameter_type), INTENT(INOUT) :: soil
TYPE(soil_snow_type), INTENT(INOUT) :: ssnow ! soil+snow variables
Expand All @@ -27,6 +27,7 @@ SUBROUTINE snow_melting (dels, snowmlt, ssnow, soil )

REAL, DIMENSION(mp,0:3) :: smelt1

ALLOCATE(snowmlt(SIZE(ssnow%smelt)))
snowmlt= 0.0
smelt1 = 0.0

Expand Down
4 changes: 1 addition & 3 deletions src/science/soilsnow/cbl_thermal.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,10 @@ SUBROUTINE snow_processes_soil_thermal(dels,ssnow,soil,veg,canopy,met,bal)
TYPE(veg_parameter_type), INTENT(INOUT) :: veg
TYPE(met_type), INTENT(INOUT) :: met ! all met forcing
TYPE (balances_type), INTENT(INOUT) :: bal
REAL, DIMENSION(mp) :: snowmlt !track snow melt
REAL, DIMENSION(:), ALLOCATABLE :: snowmlt !track snow melt
! REAL, DIMENSION(:), INTENT(INOUT) :: snowmlt ! replaced by rk4417 - phase2
INTEGER :: k,i

snowmlt = 0.0 ! inserted by rk4417 - phase2
Copy link
Copy Markdown
Collaborator

@har917 har917 May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check whether this is a science change or not


CALL snowcheck (dels, ssnow, soil, met )

CALL snowdensity (dels, ssnow, soil)
Expand Down
Loading