Improve contributor docs and test hygiene#931
Open
richardspink2 wants to merge 2 commits intoC7-Game:Developmentfrom
Open
Improve contributor docs and test hygiene#931richardspink2 wants to merge 2 commits intoC7-Game:Developmentfrom
richardspink2 wants to merge 2 commits intoC7-Game:Developmentfrom
Conversation
Closed
richardspink2
commented
May 3, 2026
Author
richardspink2
left a comment
There was a problem hiding this comment.
Here is a quick refresher of the docs and hygiene
ajhalme
reviewed
May 4, 2026
ajhalme
reviewed
May 4, 2026
ajhalme
reviewed
May 4, 2026
Contributor
|
Thanks for the contribution. The documentation changes look reasonable. I would hold on to some of the comments that are being discarded here. Pushing the test execution context logic into a helper is reasonable. A custom Civ3 test attribute could be a nice way to enable selective execution. Declaring the file dependencies at the test execution gate feels unnecessary. |
Author
|
Thanks for the review. I updated the branch to keep the Rider and CFC thread links, removed the explicit scenario file dependency lists from the test gates, and preserved the CI/local Civ3 context in the shared helper and scenario test. Verified locally with:
|
Contributor
|
Thanks. Looks fine to me. |
ajhalme
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The previous docs still referenced the old Prototype repository and older tooling. Local contributors without Civ3 installed could also hit asset-dependent test failures unless running under CI. This keeps the first-time contributor path cleaner without changing production behavior.
Validation
dotnet restore C7/C7.sln --verbosity:minimaldotnet list C7/C7.sln package --vulnerable --include-transitivedotnet build C7/C7.sln --configuration Debug --verbosity:minimaldotnet format C7/C7.sln whitespace --verify-no-changes --verbosity minimaldotnet test C7/C7.sln --logger:'console;verbosity=minimal'git diff --checkNote: the rebased upstream branch currently emits existing compiler/analyzer warnings during build, but the build exits successfully and tests pass.