Amb Reader#926
Open
stavrosfa wants to merge 4 commits intoC7-Game:Developmentfrom
Open
Conversation
Contributor
|
How are you testing the reader? Can you include some of the wiring or a manual test case? |
Contributor
Author
|
Yeah, I probably should have included something simple in the first place. I have modified the Now, I see the tests are failing because we are on github and there is no civ3 installation, so I will use what we currently use in the other tests to block it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to read .amb files.
It's by no means complete or fully tested, and could change in the future according to our needs.
It has worked well with what I have tested it so far, including with some .amb files that are known to be corrupted, I just haven't tested it with every .amb available to be sure of all the corner cases.
The
Sfxstruct is meant to be what we will be using as a sound effect data structure from now on, so even regular .wav files would have this format. This of course is also subject to change according to our needs.I have included some useful links in the code if you want more info on parsing .amb and midi files.