Repair double-encoded box-drawing characters in two K1 2025 menus - #19
Open
arlophoenix wants to merge 2 commits into
Open
Repair double-encoded box-drawing characters in two K1 2025 menus#19arlophoenix wants to merge 2 commits into
arlophoenix wants to merge 2 commits into
Conversation
The built-in camera and chassis light menus each contain two lines where U+2502 (│) was written as bytes d0 b2 e2 80 9d e2 80 9a — the correct e2 94 82 encoding read as CP1251 and re-encoded as UTF-8. They render as в”‚ and break the box borders. These four lines are the only occurrences in the repo.
The corrupt bytes were 5 wider than the character they stood in for, and the padding on three of these lines had been hand-fitted to the mangled render. With the encoding corrected they came out 1-2 columns short. Restores them to 65 columns, matching every other menu body line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four lines in the K1 2025 built-in camera and chassis light menus render as
в”‚instead of│, breaking the box borders. The bytes are U+2502 encoded as UTF-8, read back as CP1251, then encoded again —d0 b2 e2 80 9d e2 80 9asits wheree2 94 82belongs. These are the only four occurrences in the repo.Repairing the encoding exposed a smaller problem underneath it. The corrupt sequence is five bytes wider than the character it stood in for, and the padding on three of the four lines had been hand-fitted to the mangled render rather than to
│, so correcting the bytes alone left those lines one to two columns short. The second commit pads them back to 65 columns, the width of every other menu body line in the repo. Nothing else in either file is touched.Test plan
grep -rn "в”" scripts/ files/returns nothinge2 94 82; nod0 b2sequence remains anywherebash -nclean on both filesManual test pass
Not addressed
Menu body lines are 65 columns while the frame drawn by
top_line/hris 67, so body rows sit two columns narrow. That is uniform across all 117 body lines repo-wide, including boxes this PR does not touch, and correcting it is a separate change.