Skip to content

improve line number background when set to transparent #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tgilgien wants to merge 1 commit into from
Closed

improve line number background when set to transparent #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion typstwriter/editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,24 @@ def paintEvent(self, event): # This is an overriding function # noqa: N802
painter = QtGui.QPainter(self)

# paint background
painter.fillRect(event.rect(), QtGui.QColor(self.parentWidget().highlighter.line_number_background_color))
if self.parentWidget().highlighter.line_number_background_color == "transparent":
painter.fillRect(event.rect(), QtGui.QColor(self.parentWidget().highlighter.background_color))
# paint separator between line numbers and editor
color = QtGui.QColor(self.parentWidget().highlighter.background_color)
if color.value() <= 127: # mid lightness # noqa PLR2004
# QColor.lighter() works by multiplying the value with a factor and therefore has no effect if value == 0
color = QtGui.QColor("#373737") if color.value() == 0 else color.lighter(200)
else:
color = color.darker(130)
painter.setPen(QtGui.QPen(QtGui.QBrush(color), 2))
painter.drawLine(
event.rect().left() + event.rect().width(),
event.rect().top(),
event.rect().left() + event.rect().width(),
event.rect().top() + event.rect().height(),
)
else:
painter.fillRect(event.rect(), QtGui.QColor(self.parentWidget().highlighter.line_number_background_color))

# paint line numbers
painter.setPen(QtGui.QColor(self.parentWidget().highlighter.line_number_color))
Expand Down