Skip to content

[READY FOR REVIEW]: Improvement/infra-defaults — centralise and auto-fill infrastructure configurations - #130

Open
bharatsachya wants to merge 1 commit into
pre-releasefrom
fix/default
Open

[READY FOR REVIEW]: Improvement/infra-defaults — centralise and auto-fill infrastructure configurations#130
bharatsachya wants to merge 1 commit into
pre-releasefrom
fix/default

Conversation

@bharatsachya

Copy link
Copy Markdown
Contributor

What changed

  • Extracted infrastructure default handling logic (applyInfraDefaults) out of BootCommand.ts and into a new dedicated module, infraDefaults.ts.
  • Expanded default configurations to auto-fill docker mode services (Mongo URI, Neo4j URI, Redis URL, and auto-generated Neo4j password).
  • Updated applyInfraMode in infraMode.ts to seamlessly apply these defaults when switching between docker and embedded provider combinations.

Why

Default configurations were previously disjointed, with embedded mode defaults partially applied during mode selection and other defaults handled at boot. Centralising this logic ensures that switching to any infrastructure mode will automatically fill all required configuration parameters (URIs for Docker, file paths for Embedded) unless explicitly overridden. This simplifies setup and prevents startup issues caused by missing configuration keys.

How to test

  1. Clear your existing bytebell configuration overrides for database and queue providers.
  2. Run the CLI command to apply docker mode.
  3. Verify that your configuration now contains the default URIs for Mongo, Neo4j, and Redis, along with a randomly generated Neo4j password.
  4. Run the CLI command to apply embedded mode.
  5. Verify the configuration is correctly updated with the default local file paths for SQLite, Ladybug, and Queue DB.
  6. Verify the boot sequence runs correctly without missing configuration preflight errors.
  • Branch name follows the naming rules above
  • Title starts with a status tag
  • Description has What / Why / How to test sections
  • Screenshots attached (frontend PRs only)
  • All CI checks pass (formatting, build, tests)
  • Self-reviewed the diff — no leftover debug logs, commented-out code, or secrets
  • Rebased against the target branch so the diff is clean

@bharatsachya
bharatsachya requested a review from Dead-Bytes June 8, 2026 06:50
@Dead-Bytes Dead-Bytes added the Ready for Review Ready for review from reviewers label Jun 8, 2026
@ankitzm
ankitzm changed the base branch from main to pre-release June 8, 2026 20:15
@ankitzm
ankitzm self-requested a review June 8, 2026 20:15

@ankitzm ankitzm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Case: fresh installation

firstly remove the checks when embedded is selected, secondly we decided to have default links in config for the same, so let's use that please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for Review Ready for review from reviewers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants