Repository navigation
Settle finished threads on Enter so you can read the last reply - #12
Merged
Merged
Conversation
The timer moved the player away before they could read the last reply. Now Enter on a finished thread settles it and moves to the next one, and the session ends when the last thread is settled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a thread's last reply finished, the game settled the thread after 1.8 seconds and jumped to the next one. You couldn't read the final reply. The last thread had the same problem, because the end screen replaced it as soon as it finished.
Fix
Nothing settles on its own now. A finished thread stays open until you press Enter, which settles it and moves to the next thread. The session ends on the Enter that settles the last thread.
If no thread is waiting or working, Tab now picks a finished thread you haven't settled yet, so you can't get stuck.
The end screen's total time now includes the time spent reading before that last Enter.
Proof
A finished thread, 3 seconds after its last reply, still open and waiting for Enter:
The new Playwright check
checkEnterSettlesfinishes a thread and waits 3 seconds. It then checks that the thread is still active, unsettled, and showing the reply. After Enter, it checks that the thread is settled, the view moved on, and the Settled shelf shows 1. The full-session play test now presses Enter on each finished thread and still reaches the end screen with all 35 prompts sent.npm run typecheck,npm run lint, andnpm testpass. One existing check, "per-prompt wpm ignores time away", failed once at 80 wpm against a 90 floor and passed on rerun at 93. It doesn't touch settling.Reviewed with sol-loop: 1 round with gpt-6.1-sol. Sol verdict: approved
Created with Claude Opus 5.5 in Claude Code (T3 Code).
🤖 Generated with Claude Code