Skip to content

⚡ Eliminate redundant Apple notarization API call#5

Open
Bwillou1 wants to merge 1 commit into
mainfrom
fix-notarize-performance-optimization-17498450506573690578
Open

⚡ Eliminate redundant Apple notarization API call#5
Bwillou1 wants to merge 1 commit into
mainfrom
fix-notarize-performance-optimization-17498450506573690578

Conversation

@Bwillou1
Copy link
Copy Markdown
Owner

@Bwillou1 Bwillou1 commented May 8, 2026

💡 What: Eliminated a redundant xcrun altool external API call in scripts/notarize.sh by reusing the $STATUS_RESULT variable that already contains the required information. Also fixed a bug where jq selectors for hyphenated keys (e.g., notarization-info, notarization-upload) were not properly quoted, which would have caused parsing errors in jq.

🎯 Why: The script was making an additional network request to Apple's servers to retrieve the notarization log URL, even though that URL was already present in the JSON response from the previous status check. This added unnecessary latency (several seconds) and an additional point of failure.

📊 Measured Improvement: Removing an external API call involving network I/O significantly reduces the total execution time of the notarization process. While I was unable to measure the exact millisecond improvement due to the lack of xcrun in the local environment, eliminating a round-trip to Apple's servers is a guaranteed optimization. Additionally, the fix for jq selectors ensures the script correctly parses the JSON responses, preventing runtime errors.


PR created automatically by Jules for task 17498450506573690578 started by @Bwillou1

- Removed redundant `xcrun altool --notarization-info` call by reusing `$STATUS_RESULT`.
- Fixed `jq` selectors for hyphenated keys by adding mandatory quotes.
- Improved script reliability and execution speed.

Co-authored-by: Bwillou1 <162920784+Bwillou1@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant