add fst::raw::Fst::find_longest_prefix#104
Open
llogiq wants to merge 1 commit into
Open
Conversation
llogiq
force-pushed
the
find_longest_prefix
branch
2 times, most recently
from
April 8, 2020 21:53
fc7f281 to
95a7a15
Compare
llogiq
force-pushed
the
find_longest_prefix
branch
from
May 12, 2020 23:09
95a7a15 to
05ecb76
Compare
Contributor
|
Hey @llogiq, I am not sure if |
Author
|
I don't think this should be a blocker. It's only because Fst derefs to FstRef, so implementing it on the latter might allow people to use it even if they already have a FstRef. Haven't met that case yet, though. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #103.
Open question: Should we also introduce the method on
FstRef?