images: split banner vs SEO roles for memos and posts#14
Merged
Conversation
york_factory now exposes banner_image_url and seo_image_url on both memos and posts. SEO images drive social previews (OG, Twitter, JSON-LD); banner images drive featured displays only (homepage featured memo card, post slot in the homepage feed). The banner hero on the memo detail page is removed — banner is reserved for the featured spot. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Drop unused imports/vars, suppress one intentional useEffect dep warning, and migrate tracker <img> tags to next/image. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
york_factory now exposes both
banner_image_urlandseo_image_urlon memos and posts. This PR routes each image to its intended role:og:image,twitter:image, JSON-LD article image./memos/[slug],/toronto/memos/[slug]) is removed; the banner is reserved for the featured spot.Internally renamed
splashImage→bannerImageto match the API field. Dropped the now-unusedsplash_image_urlfromYFMemoDetail(the field moved to the list endpoint asbanner_image_url). AddedbannerImagetoPostDetail/MemoItemmapping for posts.Test plan
http://localhost:5050:/memos/say-it(distinct seo + banner):og:image/twitter:image/ JSON-LD image →say-it-seo.png; no banner hero rendered on the page./posts/spring-economic-update-statement:og:image/twitter:image→spring-econ-update.png.BuildCanadaSayIt.png(banner).tsc --noEmitclean.🤖 Generated with Claude Code