Skip to content

Fix array deserialisation #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mquinson merged 4 commits into from
Jul 10, 2026
Merged

Fix array deserialisation #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf01601
Add array converter in ValueSerializer.java
Wyrdix Jul 9, 2026
f9b1da0
Use of the array converter in all lessons instead of simple cast
Wyrdix Jul 9, 2026
17ce2a2
Use the right language in ExerciseTemplated error message
Wyrdix Jul 9, 2026
9b2b7fd
Change the serializer/deserializer to specify array type and enable p…
Wyrdix Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/AllDifferentEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(allDifferent(RecList.fromArray((int[])param[0]))));
setTestResult(i, serialize(allDifferent(RecList.fromArray((int[]) param[0]))));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/ButLastEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(butLast(RecList.fromArray((int[])param[0]))));
setTestResult(i, serialize(butLast(RecList.fromArray((int[]) param[0]))));
}
}

Expand Down
7 changes: 3 additions & 4 deletions src/lessons/recursion/cons/ButNfirstEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,18 @@
package lessons.recursion.cons;

import static plm.core.ValueSerializer.deserialize;
import static plm.core.ValueSerializer.serialize;

import lessons.recursion.cons.universe.ConsEntity;
import lessons.recursion.cons.universe.RecList;

import static plm.core.ValueSerializer.*;

public class ButNfirstEntity extends ConsEntity {

public void run()
{
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(butNfirst(RecList.fromArray((int[])param[0]), (Integer)param[1])));
setTestResult(i, serialize(butNfirst(RecList.fromArray((int[]) param[0]), (Integer)param[1])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/ButNlastEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(butNlast(RecList.fromArray((int[])param[0]), (Integer)param[1])));
setTestResult(i, serialize(butNlast(RecList.fromArray((int[]) param[0]), (Integer)param[1])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/ConcatEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(concat(RecList.fromArray((int[])param[0]), RecList.fromArray((int[])param[1]))));
setTestResult(i, serialize(concat(RecList.fromArray((int[]) param[0]), RecList.fromArray((int[]) param[1]))));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/IncreasingEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(increasing(RecList.fromArray((int[])param[0]))));
setTestResult(i, serialize(increasing(RecList.fromArray((int[]) param[0]))));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/IsMemberEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(isMember(RecList.fromArray((int[])param[0]), (Integer)param[1])));
setTestResult(i, serialize(isMember(RecList.fromArray((int[]) param[0]), (Integer)param[1])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/LastEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(last(RecList.fromArray((int[])param[0]))));
setTestResult(i, serialize(last(RecList.fromArray((int[]) param[0]))));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/LengthEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(length(RecList.fromArray((int[])param[0]))));
setTestResult(i, serialize(length(RecList.fromArray((int[]) param[0]))));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/MinEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(min(RecList.fromArray((int[])param[0]))));
setTestResult(i, serialize(min(RecList.fromArray((int[]) param[0]))));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/NfirstEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(nfirst(RecList.fromArray((int[])param[0]), (Integer)param[1])));
setTestResult(i, serialize(nfirst(RecList.fromArray((int[]) param[0]), (Integer)param[1])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/NlastEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(nlast(RecList.fromArray((int[])param[0]), (Integer)param[1])));
setTestResult(i, serialize(nlast(RecList.fromArray((int[]) param[0]), (Integer)param[1])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/NthEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(nth(RecList.fromArray((int[])param[0]), (Integer)param[1])));
setTestResult(i, serialize(nth(RecList.fromArray((int[]) param[0]), (Integer)param[1])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/OccurrenceEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(occurences(RecList.fromArray((int[])param[0]), (Integer)param[1])));
setTestResult(i, serialize(occurences(RecList.fromArray((int[]) param[0]), (Integer)param[1])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/PlusOneEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(plusOne(RecList.fromArray((int[])param[0]))));
setTestResult(i, serialize(plusOne(RecList.fromArray((int[]) param[0]))));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/RemoveEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(remove(RecList.fromArray((int[])param[0]), (Integer)param[1])));
setTestResult(i, serialize(remove(RecList.fromArray((int[]) param[0]), (Integer)param[1])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/cons/ReverseEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(reverse(RecList.fromArray((int[])param[0]))));
setTestResult(i, serialize(reverse(RecList.fromArray((int[]) param[0]))));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/recursion/lego/tree/TreeEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public void setPos(int i,int j) {
Color.lightGray, Color.gray, Color.darkGray, Color.black, Color.red};

@Primitive(308)
private void current(int v) {
public void current(int v) {
if (v>=colors.length || v < 0)
setColor(colors[colors.length -1]);
setColor(colors[v]);
Expand Down
2 changes: 1 addition & 1 deletion src/lessons/sort/basic/comb/AlgCombSort11Entity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public void combSort11() {
boolean swapped;
do {
if (gap>1) {
gap /= 1.3;
gap = (int) (gap / 1.3);
if (gap == 10 || gap == 9)
gap = 11;
}
Expand Down
2 changes: 1 addition & 1 deletion src/lessons/sort/basic/comb/AlgCombSortEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public void combSort() {
boolean swapped;
do {
if (gap>1)
gap /= 1.3;
gap = (int) (gap / 1.3);
swapped = false;
for (int i=0; i+gap<getValueCount(); i++)
if (!isSmaller(i,i+gap)) {
Expand Down
2 changes: 1 addition & 1 deletion src/lessons/welcome/array/array123/Array123Entity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(array123((int[])param[0])));
setTestResult(i, serialize(array123((int[]) param[0])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/welcome/array/array667/Array667Entity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(array667((int[])param[0])));
setTestResult(i, serialize(array667((int[]) param[0])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/welcome/array/arraycount9/ArrayCount9Entity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(arrayCount9((int[])param[0])));
setTestResult(i, serialize(arrayCount9((int[]) param[0])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/welcome/array/arrayfront9/ArrayFront9Entity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(arrayFront9((int[])param[0])));
setTestResult(i, serialize(arrayFront9((int[]) param[0])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/welcome/array/has271/Has271Entity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(has271((int[])param[0])));
setTestResult(i, serialize(has271((int[]) param[0])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/welcome/array/island/IslandEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(island((int[])param[0])));
setTestResult(i, serialize(island((int[]) param[0])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/welcome/array/notriples/NoTriplesEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(noTriples((int[])param[0])));
setTestResult(i, serialize(noTriples((int[]) param[0])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/welcome/array/search/AverageValueEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(averageValue((int[])param[0])));
setTestResult(i, serialize(averageValue((int[]) param[0])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/welcome/array/search/ExtremaEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(extrema((int[])param[0])));
setTestResult(i, serialize(extrema((int[]) param[0])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/welcome/array/search/IndexOfMaxValueEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(indexOfMaximum((int[])param[0])));
setTestResult(i, serialize(indexOfMaximum((int[]) param[0])));
}
}

Expand Down
3 changes: 2 additions & 1 deletion src/lessons/welcome/array/search/IndexOfValueEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import static plm.core.ValueSerializer.*;

import plm.core.model.Game;
import plm.universe.bat.BatEntity;

public class IndexOfValueEntity extends BatEntity {
Expand All @@ -11,7 +12,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(indexOf((int[])param[0], (Integer)param[1])));
setTestResult(i, serialize(indexOf((int[]) param[0], (Integer)param[1])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/welcome/array/search/MaxValueEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(maxValue((int[])param[0])));
setTestResult(i, serialize(maxValue((int[]) param[0])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/welcome/array/search/OccurrenceOfValueEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(occurrences((int[])param[0], (Integer)param[1])));
setTestResult(i, serialize(occurrences((int[]) param[0], (Integer)param[1])));
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/lessons/welcome/array/search/SecondMaxValueEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public void run()
int count = getTestCount();
for (int i = 0; i < count; i++) {
Object[] param = (Object[])deserialize(getTest(i));
setTestResult(i, serialize(max2Value((int[])param[0])));
setTestResult(i, serialize(max2Value((int[]) param[0])));
}
}

Expand Down
Loading
Loading