Conversation
…ngs 3–5) - README: soften the absolute "no credential of any kind ever enters" to the accurate claim — the MODEL credential never enters (always, via the broker); service tokens are kept out with onecli/hybrid, but a profile's `secrets:`/ `platforms:` block injects service tokens under `native`. Fixes the intro, the "What you get" bullet, and the Credential-privacy section (D-191). - threat_model §4.2: lead with the native broker as the default credential- mediation path; OneCLI is the opt-in extension (was framed as "the current integration"). Note the native+secrets service-token caveat. - threat_model §4.3: replace the stale "boolean only / unrestricted egress" with the five shipped network modes; arbitrary per-destination allowlist is the v1.0 item (points to network_egress_design.md). Doc-only. The profiles-table `build`="native" row is intentionally left pending the D-196 posture decision. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PRQ6JeWxpD9zrYcPz6VFTS
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc-only alignment from the network-egress design pass (
known_issues.mdfindings 3–5). Bias per direction: change docs to match code.Changes
native, a profile that declaressecrets:/platforms:(e.g. the default hermes preset'sdiscordplatform) injects the real service token into the sandbox — mediation brokers only the model key (D-191). Reworded the intro, the "What you get" bullet, and the Credential-privacy section to the accurate claim: model credential always out; service tokens out withonecli/hybrid.mediated/onecli/hybridrestrict egress to the proxy peer today. Arbitrary per-destination allowlist remains the v1.0 item (points atnetwork_egress_design.md).Notes for review
build= "native" row is left unchanged, pending the D-196 posture decision (findings 1–2). Finding 6 (web-search "contained" caveat) is fixed on the web-search PR Web search in Whizzard cells — firecrawl (contained) + ddgs (open) [D-194 Phase C] #38 where that section lives.🤖 Generated with Claude Code
https://claude.ai/code/session_01PRQ6JeWxpD9zrYcPz6VFTS