Fix Bifrost source-less model symbol parsing - #195
Merged
Merged
Conversation
Parse search_symbols model locations using the producer's tagged authored/model contract. Keep strict authored source identity while excluding virtual model locations from source-backed declaration matching. Add regression coverage for mixed source-less results, malformed authored locations, and same-name authored candidates in another file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the UsageBench Bifrost adapter to parse the producer's tagged authored and virtual model-location variants. Valid source-less model symbols no longer abort an entire
search_symbolsresponse, while authored symbols still require exact source identity before they can select a benchmark declaration.Key Changes:
{ path, symbol, range }and virtual{ uri, range }model locations without weakening malformed authored-location rejection.Validation:
cargo test: 273 passed.cargo run -- validate benchmarks/cases: 59 benchmark case files validated.724e596e308191d1b5c9349bfb0585e2ab135497, withJAVA_HOME='': all 18 formerly failing Java/Scala cases passed with no diagnostics. Java completed 23/23; Scala completed with 14 passes and one existing expected failure, with no hard failures or runner errors.cargo fmt --checkstill reports only pre-existing formatting drift insrc/promotion.rs; the affectedsrc/runners/bifrost.rsis formatted.cargo clippy --all-targets -- -D warningsstill reports nine pre-existing warnings outside this change's logic; the adapter-owned warning was fixed. No warnings were suppressed.Touch Points:
src/runners/bifrost.rs