Skip to content

Conversation

@dlockhart
Copy link
Member

Attempting to fix another flaky test.

This one was timing out, and I don't feel like this actually needs the 300ms timeout before appending the focusable element anyway, since it then does a waitUntil.

@dlockhart dlockhart requested a review from a team as a code owner February 5, 2026 20:58
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-6564/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

@dlockhart dlockhart changed the title GAUD-9420: remove timeout GAUD-9420: remove timeout to fix test Feb 5, 2026
@dlockhart dlockhart merged commit d42986e into main Feb 9, 2026
11 of 14 checks passed
@dlockhart dlockhart deleted the GAUD-9420/dialog-focus-fix branch February 9, 2026 14:33
@d2l-github-release-tokens
Copy link

🎉 This PR is included in version 3.213.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants