Skip to content

fix(desktop): isolate relay admission gate tests - #28

Merged
BrianInAz merged 1 commit into
mainfrom
fix/desktop-relay-admission-test-isolation
Aug 11, 2026
Merged

fix(desktop): isolate relay admission gate tests#28
BrianInAz merged 1 commit into
mainfrom
fix/desktop-relay-admission-test-isolation

Conversation

@BrianInAz

Copy link
Copy Markdown
Owner

Summary

  • add a shared test-only isolation boundary for the process-wide relay admission gate
  • reset the gate before each participating test and again when the guard drops
  • make the cross-module HTTP 429 error-message test participate in the same boundary

Root cause

oversized_hint_is_capped_in_relay_error_message_string exercised a real 429 response and armed the process-wide admission gate for the capped 300-second window. Because that test lived outside relay_admission, it did not acquire the module's shared test lock or clean up the gate. Parallel gate tests could then observe 300.001 seconds instead of their expected 5-second window.

All changes are compiled only for tests. Production admission behavior, hint clamping, and relay semantics are unchanged.

TDD evidence

  • Red: the targeted contract failed before the shared isolate_test_gate boundary existed
  • Green: isolation cleanup regression and the offending 429 test pass
  • relay library subset passed 110 tests with 5 expected ignores on five consecutive runs
  • Desktop Tauri formatting and Clippy passed
  • Desktop Tauri tests passed 2,115 tests with 15 expected ignores, plus 3 diagnostic tests
  • full just ci passed, including 1,098 mobile tests with 1 expected skip
  • git diff --check passed

Beads: ios-buzz-59e.11

Signed-off-by: Brian Charbonneau <github@briancharbonneau.com>
@cursor

cursor Bot commented Aug 11, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@BrianInAz
BrianInAz merged commit 4deea1a into main Aug 11, 2026
23 checks passed
@BrianInAz
BrianInAz deleted the fix/desktop-relay-admission-test-isolation branch August 11, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant