fix(desktop): isolate relay admission gate tests - #28
Merged
Conversation
Signed-off-by: Brian Charbonneau <github@briancharbonneau.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
oversized_hint_is_capped_in_relay_error_message_stringexercised a real 429 response and armed the process-wide admission gate for the capped 300-second window. Because that test lived outsiderelay_admission, it did not acquire the module's shared test lock or clean up the gate. Parallel gate tests could then observe 300.001 seconds instead of their expected 5-second window.All changes are compiled only for tests. Production admission behavior, hint clamping, and relay semantics are unchanged.
TDD evidence
isolate_test_gateboundary existedjust cipassed, including 1,098 mobile tests with 1 expected skipgit diff --checkpassedBeads:
ios-buzz-59e.11