fix(desktop): trust native roots for relay websockets - #22
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The HTTP relay queries succeeded because the HTTP client used platform certificate trust, while
tokio-tungstenitewas compiled with Mozilla WebPKI roots only. On systems where the relay chain is trusted through the OS certificate store, the native WSS handshake failed withUnknownIssuer. Cached/query data could still populate channels and DMs, leaving the sidebar to report that the relay was unreachable.Validation
UnknownIssuerbefore the feature change and passed afterward againstwss://buzz.bjzy.me0.5.3-bjzyacceptance build retained an established relay socket through multiple heartbeat intervals; channels/DMs loaded and the warning card remained absent