Added e-mail and password updating #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality for users to update their email address and password through the profile view. The changes include new backend API endpoints, service methods, and a redesigned frontend profile interface with collapsible forms for updating credentials.
Key Changes:
- Added
UserServicewith methods to get/update email and password - Created new REST endpoints in
UserResourcefor email and password updates - Implemented UI forms in
ProfileView.vuewith validation and loading states - Refactored
UserLoginExceptiontoUserAuthenticationExceptionfor broader authentication error handling
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
app/src/main/java/dev/blaauwendraad/recipe_book/service/UserService.java |
New service class with email/password update logic and user authentication |
app/src/main/java/dev/blaauwendraad/recipe_book/web/UserResource.java |
New REST resource providing endpoints for email/password operations with authorization checks |
app/src/main/java/dev/blaauwendraad/recipe_book/web/model/UpdateEmailRequest.java |
Request DTO for email updates with validation annotations |
app/src/main/java/dev/blaauwendraad/recipe_book/web/model/UpdatePasswordRequest.java |
Request DTO for password updates with validation annotations |
app/src/main/java/dev/blaauwendraad/recipe_book/service/exception/UserAuthenticationException.java |
Renamed exception class (formerly UserLoginException) for authentication errors |
app/src/main/java/dev/blaauwendraad/recipe_book/service/exception/UserAuthenticationExceptionMapper.java |
Updated mapper to handle renamed exception with improved error message |
app/src/main/java/dev/blaauwendraad/recipe_book/service/UserAuthenticationService.java |
Updated to throw renamed UserAuthenticationException |
app/src/main/java/dev/blaauwendraad/recipe_book/web/UserAuthenticationResource.java |
Updated login endpoint to throw renamed UserAuthenticationException |
app/src/test/java/dev/blaauwendraad/recipe_book/service/UserAuthenticationTest.java |
Updated test to reference renamed UserAuthenticationException |
app/src/main/java/dev/blaauwendraad/recipe_book/web/model/SaveRecipeRequestDto.java |
Removed duplicate @NotNull annotation from numServings field |
ui/src/api/userApi.ts |
New API client functions for email/password operations with error handling |
ui/src/components/ProfileView.vue |
Enhanced profile view with collapsible email/password update forms including validation and feedback |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/main/java/dev/blaauwendraad/recipe_book/service/UserService.java
Show resolved
Hide resolved
app/src/main/java/dev/blaauwendraad/recipe_book/web/UserResource.java
Outdated
Show resolved
Hide resolved
app/src/main/java/dev/blaauwendraad/recipe_book/service/UserService.java
Outdated
Show resolved
Hide resolved
EmielBoss
force-pushed
the
email-and-password-updating
branch
3 times, most recently
from
24b1a89 to
26a8027
Compare
EmielBoss
force-pushed
the
email-and-password-updating
branch
from
26a8027 to
f7c6b5b
Compare
Breus
reviewed
Dec 16, 2025
app/src/main/java/dev/blaauwendraad/recipe_book/service/UserService.java
Outdated
Show resolved
Hide resolved
Breus
reviewed
Dec 16, 2025
app/src/main/java/dev/blaauwendraad/recipe_book/service/UserService.java
Show resolved
Hide resolved
Breus
reviewed
Dec 16, 2025
...c/main/java/dev/blaauwendraad/recipe_book/service/exception/UserAuthenticationException.java
Outdated
Show resolved
Hide resolved
Breus
reviewed
Dec 28, 2025
app/src/main/java/dev/blaauwendraad/recipe_book/service/UserService.java
Outdated
Show resolved
Hide resolved
Breus
reviewed
Dec 28, 2025
app/src/main/java/dev/blaauwendraad/recipe_book/service/UserService.java
Outdated
Show resolved
Hide resolved
Breus
reviewed
Dec 28, 2025
app/src/main/java/dev/blaauwendraad/recipe_book/web/UserResource.java
Outdated
Show resolved
Hide resolved
Breus
reviewed
Dec 28, 2025
app/src/test/java/dev/blaauwendraad/recipe_book/service/UserAuthenticationTest.java
Show resolved
Hide resolved
Breus
reviewed
Dec 28, 2025
Breus
reviewed
Dec 28, 2025
Comment on lines
+9
to
+12
| } catch (error) { | ||
| console.error("Error fetching user: ", error); | ||
| throw error; | ||
| } |
Owner
There was a problem hiding this comment.
Why does this not have the if (error instanceof HttpError) like the ones below?
Breus
reviewed
Dec 28, 2025
ui/src/api/userApi.ts
Outdated
Comment on lines
12
to
17
| export const updateEmail = async (userId: number, newEmail: string, currentPassword: string): Promise<void> => { | ||
| try { | ||
| return await put(`/users/${userId}/email`, { newEmail, currentPassword }, {auth: "accessToken"}); | ||
| } catch (error) { | ||
| if(error instanceof HttpError) { | ||
| throw new Error(error.data.detail); |
Owner
There was a problem hiding this comment.
Why are all these functions duplicated in both userAccountApi and userApi??
Breus
reviewed
Dec 28, 2025
EmielBoss
force-pushed
the
email-and-password-updating
branch
from
2dd97f4 to
a81faf8
Compare
Breus
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.