Implement brapi side filtering, sorting, paging for germplasm - #561
Open
jloux-brapi wants to merge 1 commit into
Open
jloux-brapi wants to merge 1 commit into
jloux-brapi wants to merge 1 commit into
Conversation
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2907
Changes were made to the
BrAPIGermplasmControllerto support brapi side filtering, sorting, and paginating.It's important to note there are essentially two paths within the controller endpoint that were edited to pass through the filter/sorting/paging params:
ViewtabListstabBoth of these paths were editing to support filtering/sorting/pagination, and they work for the most part like the implementation seen in the
BrAPITrialsControllerThere are, however, several problems found while working on this effort and testing that are going to need to be resolved as separate tickets/efforts once it was found the scope to be too large to include in this ticket:
The first, is that it was found the way germplasm
createDaterecords are stored inadditionalInfois entirely different than the format displayed in the table.This means the way of sorting/filtering on a string like mm-dd-yyyy will not work like it does for Trials. This issue causes a unit test failure, and that unit test has been marked to be fixed once a solution is decided upon to deal with this. This effort is captured as BI-3057
Secondly, alphanumeric sorting is not working and sorting the same as typically expected on the DeltaBreed frontend. This is because of several factors, and is the subject of this SPIKE/bug ticket: BI-3052
Finally, the code for the Germplasm Lists tab was predicated on editing existing importEntryNumber data on the fly and then sorting the data later.
This kind of implementation is not suitable for brapi side pagination/sorting/filtering, and in order to implement this properly, the data will have to be stored in a different way on the BrAPI side so that it will be possible to achieve brapi side filtering. This effort is still being scoped and is likely to take a good bit of effort, and is tracked by this ticket: BI-3058
Dependencies
brapi-java-prod-server feature/BI-2907
Testing
General germplasm regression, with focus on:
ViewtabListstabAs stated above, it's expected that the sorting/filtering for
Entry Numberin theListstab is not working. This is the subject of another ticket, and will not be addressed here.Checklist: