Skip to content

Implement brapi side filtering, sorting, paging for germplasm - #561

Open
jloux-brapi wants to merge 1 commit into
feature/BI-2906from
feature/BI-2907
Open

jloux-brapi wants to merge 1 commit into
feature/BI-2906from
feature/BI-2907

Conversation

@jloux-brapi

@jloux-brapi jloux-brapi commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Story: BI-2907

Changes were made to the BrAPIGermplasmController to support brapi side filtering, sorting, and paginating.

It's important to note there are essentially two paths within the controller endpoint that were edited to pass through the filter/sorting/paging params:

  • Germplasm View tab
  • Germplasm Lists tab

Both of these paths were editing to support filtering/sorting/pagination, and they work for the most part like the implementation seen in the BrAPITrialsController

There are, however, several problems found while working on this effort and testing that are going to need to be resolved as separate tickets/efforts once it was found the scope to be too large to include in this ticket:

The first, is that it was found the way germplasm createDate records are stored in additionalInfo is entirely different than the format displayed in the table.

This means the way of sorting/filtering on a string like mm-dd-yyyy will not work like it does for Trials. This issue causes a unit test failure, and that unit test has been marked to be fixed once a solution is decided upon to deal with this. This effort is captured as BI-3057

Secondly, alphanumeric sorting is not working and sorting the same as typically expected on the DeltaBreed frontend. This is because of several factors, and is the subject of this SPIKE/bug ticket: BI-3052

Finally, the code for the Germplasm Lists tab was predicated on editing existing importEntryNumber data on the fly and then sorting the data later.

This kind of implementation is not suitable for brapi side pagination/sorting/filtering, and in order to implement this properly, the data will have to be stored in a different way on the BrAPI side so that it will be possible to achieve brapi side filtering. This effort is still being scoped and is likely to take a good bit of effort, and is tracked by this ticket: BI-3058

Dependencies

brapi-java-prod-server feature/BI-2907

Testing

General germplasm regression, with focus on:

  • Germplasm View tab
  • Germplasm Lists tab

As stated above, it's expected that the sorting/filtering for Entry Number in the Lists tab is not working. This is the subject of another ticket, and will not be addressed here.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit and/or integration tests to cover this change or tests are not applicable
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant