[BI-2755] - improve default sub-unit sort#491
Merged
nickpalladino merged 2 commits intodevelopfrom Dec 17, 2025
Merged
Conversation
nickpalladino
approved these changes
Dec 16, 2025
Member
nickpalladino
left a comment
There was a problem hiding this comment.
When testing the only thing that was a little misleading was dataset table showing the table column sort arrow being on EnvYear when that's not really the sorting that is being shown. I'm ok moving this through but we may want to change that in a future card.
7 tasks
Contributor
Author
Good catch, it's a small change so added a bi-web branch to PR Breeding-Insight/bi-web#452 |
Member
|
tested with new front-end change and looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2755 - improve default sub-unit sort
Updated BrAPITrialService:sortDefaultForObservationUnit to conditionally sort data depending on whether the dataset is top level or sub entity, and in the case of sub-entity sort by environment > experimental unit id > sub unit id
Dependencies
bi-web: BI-2755
Testing
Create an experiment with multiple environments and a sub-entity dataset
On the top level dataset tab: ensure table is sorted by Env > Exp Unit ID
On the sub entity tab: ensure table is sorted by Env > Exp Unit ID > Sub Unit ID
Checklist: