Dev by ackermanar · Pull Request #4 · Breeding-Insight/Morphometric-Analysis-Toolbox-for-Segmentation

ackermanar · 2026-09-21T20:49:46Z

Added agents for main and updated numpy dependencies

First-round edits to README, prior to attempting installation

…r for larger birefnet weights

Initial README edits, edited to resolve conflicts with dev branch

Ported from main (fbb3c09) onto dev at e7904eb. Agent instructions and docs - AGENTS.md: public agent guide, the single source of truth; CLAUDE.md imports it. docs/faq.md: human FAQ, linked from the README. - .gitignore: commit CLAUDE.md and AGENTS.md; ignore *.local.md. - README, FAQ, AGENTS: Git LFS is an install prerequisite (a clone made without it yields a 134-byte pointer stub, not the model), RF-DETR arrives with the clone, and `mats fetch-weights` is the repair path. Repair uses `git lfs pull --exclude=weights/birefnet_leaf.pth`, which stays RF-DETR-only whether or not .lfsconfig's fetchexclude is active. - README: reconciled with the restructure from PR #2; its headings and TOC are kept, and the hand-edited doctor/fetch paragraph is preserved verbatim. Also carried over from fbb3c09 (app work, unrelated to the docs) - src/mats/app/Home.py, branding.py, src/mats/core.py, pyproject.toml, tests/test_home_app.py Known and not addressed here - .lfsconfig has fetchexclude commented out on dev, so a clone now fetches BiRefNet (2.65 GB) as well as RF-DETR. - tests/test_weights.py::test_status_missing_for_excluded_checkout_pointer already fails on dev before this commit (message reworded in PR #2). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

ackermanar · 2026-09-22T13:31:10Z

Pulling dev into main with new birefnet ease of integration.

Copilot

Copilot review overview

🔵 Needs a closer look

The checkpoint source selection issue and contradictory documentation should be addressed before approval.

Review effort: Lite
Findings: None

What changed in this PR

Updates Git LFS handling for the optional BiRefNet checkpoint and improves dependency-gated tests and documentation.

Changes:

Makes BiRefNet fetching opt-in with checkpoint-specific commands.
Expands RF-DETR and BiRefNet fetch tests.
Skips NumPy-dependent tests when NumPy is unavailable.
Updates setup and LFS guidance.

File	Summary
`tests/test_weights.py`	Tests checkpoint-specific LFS fetch behavior.
`tests/test_home_app.py`	Gates tests on NumPy availability; PR scope description does not match the provided changes. (nit, 1 vote)
`src/mats/weights.py`	Adds checkpoint fetch logic; hard-coded `--source lfs` may fail outside Git LFS checkouts. (moderate, 1 vote)
`src/mats/app/pages/2_BiRefNet_Setup.py`	Updates the manual BiRefNet fetch command.
`README.md`	Updates project guidance; bare `git lfs pull` instructions conflict with the new exclusion behavior. (nit, 1 vote)
`docs/weights.md`	Documents opt-in BiRefNet fetching; related download guidance remains inconsistent. (nit, 1 vote)
`.lfsconfig`	Enables BiRefNet fetch exclusion, requiring corresponding documentation updates. (nit, 1 vote)
`.gitattributes`	Updates LFS guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

Copilot review overview

🟡 Changes recommended

Several user-facing instructions contradict the new LFS behavior, and the stated NumPy dependency update is absent.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2

Open (2)

Update bare git LFS pull documentation · New
Update docs for corrected LFS weights destination · New

Previously missed (1)

In code that hasn't changed since last review

NumPy dependency declaration remains unchanged

tests/test_home_app.py:7

The PR description says NumPy dependencies were updated, but this only skips the app tests when NumPy is unavailable; pyproject.toml:38 still has the same unversioned numpy dependency. Please either make the intended dependency change in the package/environment declarations or revise the PR description so it matches the actual change.

Copilot

Copilot review overview

🟢 Approval recommended

The implementation, tests, configuration, and documentation consistently enforce explicit BiRefNet downloads.

Review effort: Balanced
Findings: 2

Open (2)

Update docs for corrected LFS weights destination
Update bare git LFS pull documentation

ackermanar · 2026-09-22T14:57:06Z

@tyrwh would you be able to review and approve this branch for merge?

tyrwh

Approving review

tyrwh

Trying review again

tyrwh

Third time's the charm

tyrwh and others added 11 commits July 31, 2026 09:59

Initial README edits

7b6efdf

First-round edits to README, prior to attempting installation

changing git-lfs calls and .lfsignore to get desired download behavio…

0a8644e

…r for larger birefnet weights

Merge branch 'dev' into tyr_suggestions

f940ba0

Merge pull request #2 from Breeding-Insight/tyr_suggestions

e7904eb

Initial README edits, edited to resolve conflicts with dev branch

tests: skip home app tests without numpy

c48405b

weights: restore optional BiRefNet LFS fetch

5adbab6

docs: correct explicit BiRefNet LFS pull

6552ee4

Merge branch 'main' into dev

18c1a01

fixed dependency light ci

aeab737

Update README.md (#5)

c4dec31

ackermanar requested a lite review from Copilot September 22, 2026 13:41

Copilot started reviewing on behalf of ackermanar September 22, 2026 13:42 View session

Copilot AI reviewed Sep 22, 2026

View reviewed changes

fixed contradicotry documentation and markdown

5cf3af6

ackermanar requested a balanced review from Copilot September 22, 2026 14:45

ackermanar self-assigned this Sep 22, 2026

Copilot started reviewing on behalf of ackermanar September 22, 2026 14:46 View session

Copilot AI reviewed Sep 22, 2026

View reviewed changes

Comment thread .lfsconfig

Comment thread docs/weights.md

fixed contradicotry documentation in .md files and agents

41b1c60

ackermanar requested a balanced review from Copilot September 22, 2026 14:53

Copilot started reviewing on behalf of ackermanar September 22, 2026 14:54 View session

Copilot AI reviewed Sep 22, 2026

View reviewed changes

ackermanar requested a review from tyrwh September 22, 2026 14:57

tyrwh reviewed Sep 22, 2026

View reviewed changes

ackermanar closed this Sep 22, 2026

ackermanar reopened this Sep 22, 2026

ackermanar requested a review from tyrwh September 22, 2026 16:19

tyrwh reviewed Sep 23, 2026

View reviewed changes

tyrwh closed this Sep 23, 2026

tyrwh reopened this Sep 23, 2026

tyrwh self-requested a review September 23, 2026 14:00

tyrwh approved these changes Sep 23, 2026

View reviewed changes

ackermanar merged commit 190132d into main Sep 23, 2026
9 checks passed

Navigation Menu

Dev - #4

Dev#4
ackermanar merged 13 commits into
mainfrom
dev

ackermanar commented Sep 21, 2026

Uh oh!

ackermanar commented Sep 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

ackermanar commented Sep 22, 2026

Uh oh!

tyrwh left a comment

Uh oh!

tyrwh left a comment

Uh oh!

tyrwh left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ackermanar commented Sep 21, 2026

Uh oh!

ackermanar commented Sep 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

ackermanar commented Sep 22, 2026

Uh oh!

tyrwh left a comment

Choose a reason for hiding this comment

Uh oh!

tyrwh left a comment

Choose a reason for hiding this comment

Uh oh!

tyrwh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants