Skip to content

Conversation

@Breakthrough
Copy link
Owner

This PR changes how event merging works, fixing #72 and #192:

  • Event merging is no longer controlled by the time-before-event (-tb) and time-post-event (-tp) options
    • These continue to influence how the output video clips are handled
  • A new parameter is added called minimum event distance (option: --min-event-dist), which controls how long after a motion event starts we continue appending frames with motion.
  • The output event list is always the first frame with motion to the last frame with motion, padded by the time before/post options

@Breakthrough Breakthrough modified the milestones: v1.8, v1.7 Feb 5, 2025
@Breakthrough
Copy link
Owner Author

Breakthrough commented Feb 18, 2025

I think the most realistic way to approach this is to rewrite the scan logic of MotionScanner in a ground up way that supports this from the start. We have good tests now so this shouldn't be too much of an issue, but we need to add new ones for the new behaviour. This is a good time to probably add fake videos and subtractors to facilitate easier and quicker unit tests, and allow testing for weird edge cases with far less effort.

Unfortunately this may need to be bumped to v1.8 however.

@Breakthrough Breakthrough modified the milestones: v1.7, v1.8 Feb 18, 2025
@Breakthrough Breakthrough force-pushed the main branch 2 times, most recently from d40559b to d8f084d Compare July 13, 2025 00:24
@Breakthrough Breakthrough force-pushed the main branch 4 times, most recently from 6ffa59e to 5cefd51 Compare August 17, 2025 02:28
@Breakthrough Breakthrough force-pushed the main branch 2 times, most recently from a38ce9d to 5711a36 Compare October 5, 2025 04:43
@Breakthrough Breakthrough force-pushed the main branch 12 times, most recently from 904dc78 to 6e7e0ef Compare November 17, 2025 03:25
@Breakthrough Breakthrough force-pushed the main branch 20 times, most recently from 36b111d to cea454e Compare November 18, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants