LEGUP 7.1.0#982
Merged
Merged
Conversation
# Conflicts: # .github/workflows/publish-javadoc.yml # src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipElementView.java # src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipExporter.java # src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipImporter.java # src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipView.java # src/test/java/puzzles/shorttruthtable/rules/BiconditionalCaseRuleTest.java # src/test/java/puzzles/shorttruthtable/rules/OrIntroductionTest.java
This reverts commit 7b9396e.
This reverts commit 15f0f29.
# Conflicts: # .github/workflows/publish-javadoc.yml # src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipElementView.java # src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipExporter.java # src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipImporter.java # src/main/java/edu/rpi/legup/puzzle/battleship/BattleshipView.java # src/test/java/puzzles/shorttruthtable/rules/BiconditionalCaseRuleTest.java # src/test/java/puzzles/shorttruthtable/rules/BiconditionalContradictionRuleTest.java # src/test/java/puzzles/shorttruthtable/rules/OrIntroductionTest.java
Goal conditions
main thing is adding be in front of overridden so that the rest of the sentence makes sense when talking about overriding methods.
… or not they're a basic/case/contradiction/ rule
Did almost all the comment in the possible Number Case Board class
Clarifying documentation.
Draws a brown highlight on cells that have been marked as goal conditions.
Clarifying documentation.
Removed lots of duplicate code by having mouseEntered call mouseMoved for hover assignments, and made mouseExited look if any elements are currently hovered, rather than for elements currently under cursor.
Moved goal parsing below tile parsing so the isGoal flag can be applied to existing elements rather than storing locations for later.
added comments to the model Sudoku boards class
added comments to the Sudoku board class as well as Element View class
Goal condition cell rendering
JetBrains
Fix Publish-Javadoc Action
Fix issues with multiple calls to getCases() Align similar puzzle left/right click actions to be the same (Nurikabe and Filapix) Add documentation to test cases
Add comments to HeyAwake, Treetent, Thermometer, and Star Battle Add a few JetBrains annotations to some engine classes.
# Conflicts: # src/main/java/edu/rpi/legup/controller/ElementController.java # src/main/java/edu/rpi/legup/model/PuzzleExporter.java # src/main/java/edu/rpi/legup/model/gameboard/GridBoard.java # src/main/java/edu/rpi/legup/puzzle/lightup/LightUpCell.java # src/main/java/edu/rpi/legup/puzzle/nurikabe/NurikabeImporter.java # src/main/java/edu/rpi/legup/puzzle/starbattle/StarBattleCellFactory.java # src/main/java/edu/rpi/legup/puzzle/treetent/TreeTentCell.java # src/main/java/edu/rpi/legup/ui/PuzzleEditorPanel.java # src/main/resources/edu/rpi/legup/VERSION
Full implementation of Goal Conditions
Javadoc descriptions
Implement Default Case Rule Check
Creating SvgIcon keys so Puzzle can have transparency and making new visual elements in ProofEditor and PuzzleEditor look more similar.
Svg Icons and UI Customization
Automated Java code formatting changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pushing updates from Spring 2026 Semester
Closes many issues
Type of change
How Has This Been Tested?
The application has been demonstrated during the RCOS expo.
Checklist: