Dev#975
Merged
Merged
Conversation
that function was called twice consecutively with .size() to get the number of cases. It's better if it's only called once and the size is stored into a variable.
.getCases() for Nurikabe in BlackOrWhiteCaseRule.java is now called only once. I don't know what "dependentElements" had to do with it.
…xed the similar issue for fillapix
Ongoing task: add comments that describe what each minesweeper test does/checks for.
comments that describe what minesweeper tests are checking for. also identifying possible corner cases that aren't being tested yet.
Previously Nurikabe was right click->cell turns black, left click->cell turns white, and Fillapix was the reverse of that. That was confusing. I have made it so that Nurikabe works as: left click->cell turns black, right click->cell turns white
I identified a corner case for Minesweeper's FinishWithMinesDirectRule that was not thoroughly tested so I added another build test and checked it
This function name was misleading about what it was meant to do.
Documentation
Documentation
Documentation
jadeandtea
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I fixed issue #724, the nurikabe getCasesI() issue. I switched the use of the right and left click for nurikabe to be functionally consistent with the fillapix UI. I also wrote documentation.
Closes #724
Type of change
How Has This Been Tested?
I tested the changes I made, building and running. I also wrote a build test.
Checklist: