Integrate baselines from CNMC_PAI (organizer baseline)#143
Conversation
There was a problem hiding this comment.
Pull request overview
Adds BraTS25_B (organizer baseline) entries for seven BraTS25 task algorithms — Adult Glioma Pre/Post, Africa, Meningioma, Meningioma RT, Metastases, Pediatric, and Inpainting — plumbing them through enums, YAML metadata, README tables, and updating the rank-integrity test to recognize the new B suffix.
Changes:
- Add
BraTS25_Benum members inbrats/constants.pyand matching YAML entries (withaparida12/brats2025:*Docker images) in seven task metadata files, including a newBaselinerank anchor in each. - Update
tests/utils/test_algorithm_config.pyrank parser to map suffixB→Baselinewhile preserving existing tie-suffix handling. - Add README rows and an explanatory footnote for each new baseline, plus a BraTS-PEDs 2026 dataset paper link.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| brats/constants.py | Adds BraTS25_B enum entries with docstrings to seven *Algorithms enums |
| brats/data/meta/adult_glioma_pre_and_post_treatment.yml | New baseline anchor and BraTS25_B entry using aparida12/brats2025:gli |
| brats/data/meta/africa.yml | New baseline anchor and BraTS25_B entry using aparida12/brats2025:ssa (requires_root) |
| brats/data/meta/meningioma.yml | New baseline anchor and BraTS25_B entry using aparida12/brats2025:men |
| brats/data/meta/meningioma_rt.yml | New baseline anchor and BraTS25_B entry using aparida12/brats2025:menrt (requires_root) |
| brats/data/meta/metastases.yml | New baseline anchor and BraTS25_B entry using aparida12/brats2025:met (requires_root) |
| brats/data/meta/pediatric.yml | New baseline anchor and BraTS25_B entry using aparida12/brats2025:peds (requires_root) |
| brats/data/meta/inpainting.yml | New baseline anchor and BraTS25_B entry using aparida12/brats2025:inpt |
| tests/utils/test_algorithm_config.py | Extends rank parsing to map suffix B to Baseline |
| README.md | Adds Baseline* rows and footnotes for seven task sections, plus a PEDs 2026 dataset paper link |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Astarakee as I understand it your baseline is not integrated here? Should we integrate these into this same PR? Probably the Enums should account for the two Baselines, maybe by going for |
I used BraTS25_B to be consistent with the format for the other Enums. We could use BraTS25_B1, B2... for Baseline 1, Baseline 2 etc.? |
I will follow the same way that Zhifan applied; for GLI, METs, MENpre, and MENrt all in 2025. |
Okay, I suggest having both baselines in the same PR, so please build upon @zjiang0529 's work and extend this PR. Would that work for you? |
|
@MarcelRosier should we download the docker images and reupload them to our repo, or keep it as it is? |
For me that suggests some kind of ranking between the baselines, hence I proposed |
Have we decided on the name yet? A/B is clearer than 1/2, but using BraTS25_Baseline_A and B could make the columns wider and have three parts. Maybe BraTS25_BaselineA/B or BraTS25_BA/BB? |
In response to Issue #116, add baselines from CNMC_PAI for 7 tasks.