Fix export logic issues in TracerouteHopInfo and WiFiNetworkInfo #3291
+38
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Following the patterns from PR #3290, analyzed all 19 export manager files for similar issues. Found and fixed 4 bugs in 2 files:
TracerouteHopInfo.cs
Status3andTime3fields?.) for allIPGeolocationResult.Infoproperty accesses across CSV, XML, and JSON exports to prevent NullReferenceExceptionWiFiNetworkInfo.cs
ChannelCenterFrequencyInKilohertzwas incorrectly assignedSsidvalue.) to comma (,) separator betweenBeaconIntervalandUptimeExample of fixes applied:
Related issue(s)
Analysis requested based on PR #3290 patterns
Copilot generated summary
Copilot summary
Analyzed all export manager files following PR #3290 patterns. Fixed CSV formatting bugs (missing/incorrect separators), null safety issue (potential NullReferenceException in geolocation data access), and data integrity bug (wrong field assignment in WiFi JSON export). Code review and CodeQL scan passed with no issues.
To-Do
Contributing
By submitting this pull request, I confirm the following:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.