Add MeshBool::sphere() - #13
Merged
Merged
Conversation
JaminKoke
commented
Dec 7, 2025
JaminKoke
force-pushed
the
sphere
branch
2 times, most recently
from
December 8, 2025 03:42
01a7d48 to
afb6b80
Compare
Contributor
Author
Contributor
Author
Contributor
Author
|
I believe this is all good now! I just removed rayon from this because I'm not sure how we want to do add it. Manifold uses set thresholds to decide whether or not to do parallel execution, and I don't know if rayon's |
Member
|
With this feature being non-critical and the test suite project coming to a close, I'm going to start being less rigorous with reviewing. Also that screenshot looks convincingly spherical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


So I wanted to add sphere for the test suite, but it was bigger than I though, and it is also tripping an assert when I run it with the test suite.
As of now I am unable to figure out why it's not working, so if you happen to notice something I missed, let me know!
If not, no worries. I'll keep working on figuring it out.
I think maybe this is possibly ready now!(Read latest comment) I have not really tested it very well.