Skip to content

Add MeshBool::sphere() - #13

Merged
luisfonsivevo merged 1 commit into
BorgerLand:masterfrom
JaminKoke:sphere
Jan 6, 2026
Merged

luisfonsivevo merged 1 commit into
BorgerLand:masterfrom
JaminKoke:sphere

Conversation

@JaminKoke

@JaminKoke JaminKoke commented Dec 6, 2025

Copy link
Copy Markdown
Contributor

So I wanted to add sphere for the test suite, but it was bigger than I though, and it is also tripping an assert when I run it with the test suite.

[ RUN      ] Properties.ToleranceSphere

thread '<unnamed>' panicked at src/meshboolimpl.rs:176:13:
topological degeneracy
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

As of now I am unable to figure out why it's not working, so if you happen to notice something I missed, let me know!
If not, no worries. I'll keep working on figuring it out.

I think maybe this is possibly ready now! (Read latest comment) I have not really tested it very well.

Comment thread src/subdivision.rs Outdated
@JaminKoke
JaminKoke force-pushed the sphere branch 2 times, most recently from 01a7d48 to afb6b80 Compare December 8, 2025 03:42
@JaminKoke

Copy link
Copy Markdown
Contributor Author

Whoops
image

@JaminKoke

Copy link
Copy Markdown
Contributor Author
image

@JaminKoke JaminKoke changed the title WIP: MeshBool::sphere() Add MeshBool::sphere() Dec 8, 2025
@JaminKoke
JaminKoke marked this pull request as ready for review December 8, 2025 20:47
@JaminKoke

Copy link
Copy Markdown
Contributor Author

I believe this is all good now! I just removed rayon from this because I'm not sure how we want to do add it. Manifold uses set thresholds to decide whether or not to do parallel execution, and I don't know if rayon's with_min_len() function is the correct thing to use. (I guess it could be further discussed in #14 )

@luisfonsivevo

Copy link
Copy Markdown
Member

With this feature being non-critical and the test suite project coming to a close, I'm going to start being less rigorous with reviewing. Also that screenshot looks convincingly spherical.

@luisfonsivevo
luisfonsivevo merged commit 0e1a5d0 into BorgerLand:master Jan 6, 2026
@JaminKoke
JaminKoke deleted the sphere branch January 6, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants