Repository navigation
Release 0.4.1 - #5
Merged
Merged
Conversation
Makes the published crate match its tag. The publishability fix landed after cli-v0.4.0 was already tagged and released, so publishing under 0.4.0 would have put a crate on crates.io whose contents differed from the tag and the release archives. A crates.io version can be yanked but never reused, so that divergence would have been permanent. 0.4.1 is the first version where the tag, the binaries and the crate are the same code. No user-visible behaviour change, so PATCH per the policy in CHANGELOG.md. One detail worth recording: the version pin on the bootintel-detectors path dependency has to track the workspace version. Bumping only the workspace would leave crates/cli asking the index for 0.4.0 while publishing 0.4.1. Verified: 274 tests pass, cargo deny reports advisories, bans, licenses and sources all ok, rustfmt clean, and the library packages. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the published crate match its tag.
The publishability fix (#4) landed after
cli-v0.4.0was already tagged and released. Publishing under 0.4.0 would have put a crate on crates.io whose contents differed from the tag and the release archives, and since a crates.io version can be yanked but never reused, that divergence would be permanent. 0.4.1 is the first version where the tag, the binaries and the crate are all the same code.No user-visible behaviour change, so PATCH per the policy in CHANGELOG.md.
One detail worth flagging: the version pin on the
bootintel-detectorspath dependency has to track the workspace version. Bumping only the workspace would leavecrates/cliasking the index for 0.4.0 while publishing 0.4.1.Verified locally: 274 tests pass,
cargo deny checkreports advisories, bans, licenses and sources all ok, rustfmt clean, andcargo package -p bootintel-detectorssucceeds.After merge: dispatch
cli-releasewith version0.4.1andpublish_crateschecked.