Skip to content

Fix undefined symbol errors with Ruby 2.7+ #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aashutosh-sahni wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix undefined symbol errors with Ruby 2.7+ #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72b143a
Fix C function names conflicting with ISO C alternative tokens
aashutosh-sahni May 4, 2026
b95d1c4
Use static linkage for bitset helper functions
aashutosh-sahni May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ext/bitset/bitset.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,10 +556,10 @@ static VALUE rb_bitset_equal(VALUE self, VALUE other) {
}

typedef uint64_t (*bitwise_op)(uint64_t, uint64_t);
inline uint64_t and(uint64_t a, uint64_t b) { return a & b; }
inline uint64_t or(uint64_t a, uint64_t b) { return a | b; }
inline uint64_t xor(uint64_t a, uint64_t b) { return a ^ b; }
inline uint64_t difference(uint64_t a, uint64_t b) { return a & ~b; }
static uint64_t bitset_and(uint64_t a, uint64_t b) { return a & b; }
static uint64_t bitset_or(uint64_t a, uint64_t b) { return a | b; }
static uint64_t bitset_xor(uint64_t a, uint64_t b) { return a ^ b; }
static uint64_t bitset_difference(uint64_t a, uint64_t b) { return a & ~b; }

static VALUE mutable(VALUE self, VALUE other, bitwise_op operator) {
Bitset * bs = get_bitset(self);
Expand All @@ -578,19 +578,19 @@ static VALUE mutable(VALUE self, VALUE other, bitwise_op operator) {
}

static VALUE rb_bitset_union_mutable(VALUE self, VALUE other) {
return mutable(self, other, &or);
return mutable(self, other, &bitset_or);
}

static VALUE rb_bitset_intersect_mutable(VALUE self, VALUE other) {
return mutable(self, other, &and);
return mutable(self, other, &bitset_and);
}

static VALUE rb_bitset_xor_mutable(VALUE self, VALUE other) {
return mutable(self, other, &xor);
return mutable(self, other, &bitset_xor);
}

static VALUE rb_bitset_difference_mutable(VALUE self, VALUE other) {
return mutable(self, other, &difference);
return mutable(self, other, &bitset_difference);
}

static VALUE rb_bitset_reset(VALUE self) {
Expand Down